----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120505/ -----------------------------------------------------------
Review request for Calligra, Dmitry Kazakov and Boudewijn Rempt. Repository: calligra Description ------- This patch adds a little eye icon underneath the deletion icon which can be used to activate/deactivate snapping and in the case of the perspective assistant, add a preview for where the snapping will happen/head to. This last bit of code may be refactored a little more, if I want to allow to option to see this preview without having the basic assistant visible. This would allow these previews to make sense on normal assistants as well. (Right now, the 'hide assistants' button in view just makes the whole widget invisible). Preview will be important if we're gonna have parallel rulers and the like. I also fixed a minor bug where the canvas wasn't passed to the drawAssistant function in the painting assistant by the PaintingAssistantDecorations class, because whoever wrote the caching system had added a boolean for it in the arguments in a rather random place. Both caching and me accessing the canvas for cursor conversion work now. Diffs ----- krita/plugins/assistants/RulerAssistant/EllipseAssistant.cc ec6ee06 krita/plugins/assistants/RulerAssistant/PerspectiveAssistant.h c4fd3b2 krita/plugins/assistants/RulerAssistant/PerspectiveAssistant.cc e3ec525 krita/plugins/assistants/RulerAssistant/RulerAssistant.cc dd173c0 krita/plugins/assistants/RulerAssistant/SplineAssistant.cc 8391f65 krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.h 11e92f3 krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc bbfe5cd krita/ui/canvas/kis_canvas_decoration.cc 9179d3f krita/ui/canvas/kis_canvas_widget_base.cpp 02f0ab5 krita/ui/kis_painting_assistant.h 6f315e8 krita/ui/kis_painting_assistant.cc 81c6069 krita/ui/kis_painting_assistants_decoration.cpp dd65ec0 Diff: https://git.reviewboard.kde.org/r/120505/diff/ Testing ------- Lots, I can't find any crashes or bugs here. Thanks, Wolthera van Hövell
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
