----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115512/#review68472 -----------------------------------------------------------
Hi Yue, Is this patch still relevant? - Boudewijn Rempt On Feb. 6, 2014, 2:44 a.m., Yue Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115512/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 2:44 a.m.) > > > Review request for Calligra and Camilla Boemann. > > > Repository: calligra > > > Description > ------- > > Added "Add Text" action to popup menu in DefaultTool, if an application don't > want it appear in popup menu, set AllowAddTextToShapePopupAction=false in rc > file. Currently disabled in Words, Sheets, and Kexi. > > There is a problem that KoTosContainer doesn't have API to delete text shapes > in it, so undo doesn't work. > > Another thing is this action supports adding text to multiple shapes, after > texts are added, should it activate text tool automatically? If there are > multiple shapes, which one should have text tool activated? The first in > list, or the one under cursor? If the shape under cursor is not a > KoTosContainer, then which KoTosContainer should have TextTool activated? My > current idea is if the shape under cursor is KoTosContainer, then activate > TextTool on it, otherwise don't activate TextTool. > > > Diffs > ----- > > kexi/data/kexirc 4c73bd0 > libs/flake/CMakeLists.txt 839b861 > libs/flake/commands/KoTosContainerAddTextCommand.h PRE-CREATION > libs/flake/commands/KoTosContainerAddTextCommand.cpp PRE-CREATION > plugins/defaultTools/defaulttool/DefaultTool.h dca6ae8 > plugins/defaultTools/defaulttool/DefaultTool.cpp 453a727 > sheets/sheetsrc 9b622fb > words/part/wordsrc 4cd2801 > > Diff: https://git.reviewboard.kde.org/r/115512/diff/ > > > Testing > ------- > > Works on OSX > > You can also test through branch add-text-popup-action-yue > > > Thanks, > > Yue Liu > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
