----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120593/ -----------------------------------------------------------
(Updated Oct. 15, 2014, 10:29 p.m.) Status ------ This change has been marked as submitted. Review request for Calligra. Repository: calligra Description ------- Currently the popup docker has a nasty bug that has really been bothering me when painting. When you open it up and select a color from the triangle, it doesn't behave correctly. If you try to select a color that has no saturation (greyscale), the triangle will rotate around to the hue red. The same thing will happen when selecting black/white. This happens a lot when selecting really dark colors or really light. Diffs ----- krita/ui/kis_popup_palette.cpp ebebe82 libs/widgets/KoTriangleColorSelector.cpp aede069 Diff: https://git.reviewboard.kde.org/r/120593/diff/ Testing ------- I am on Ubuntu 14.04, so I am not sure if the bug is present on other OSs. I tested it out for a while selecting all different colors. I tried releasing the mouse at different times. It seems to be working to me. The fix: There are a lot of get/set calls for each hue, saturation, and value call within the triangle color selector. Some of them were called directly, while others were called through their getter/setter methods. I think the different ways were stomping on each other. I made all calls use the getters/setters so they go through the proper data sanitization. Removed extra sanitization on outside steps. Thanks, Scott Petrovic
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
