----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121088/#review70446 -----------------------------------------------------------
Tried the patch on current master (does not cleanly merge, but think I resolved things as needed), and could no longer reproduce the bug :) kexi/main/KexiMenuWidget.cpp <https://git.reviewboard.kde.org/r/121088/#comment49268> Please add a comment what this condition checks and what the other calculation of 'bottomMargin' does actually different. Not immediate obvious from just looking at the variables used. kexi/main/KexiMenuWidget.cpp <https://git.reviewboard.kde.org/r/121088/#comment49266> why not `int logoBottomMargin = d->logoBottomMargin();` but copy constructor? At least inconsistent with rest of the code. - Friedrich W. H. Kossebau On Nov. 14, 2014, 2:09 nachm., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121088/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 2:09 nachm.) > > > Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Radosław > Wicik, and Wojciech Kosowicz. > > > Bugs: 340767 > http://bugs.kde.org/show_bug.cgi?id=340767 > > > Repository: calligra > > > Description > ------- > > Fix position of the Calligra logo based on height of the main menu > > > Diffs > ----- > > kexi/main/KexiMenuWidget.h f5b418e > kexi/main/KexiMenuWidget.cpp 6acd27e > kexi/main/KexiMenuWidget_p.h 2463b9b > > Diff: https://git.reviewboard.kde.org/r/121088/diff/ > > > Testing > ------- > > Logo well displayed regardless of the menu height. > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
