----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121389/#review72755 -----------------------------------------------------------
Ship it! Ship It! - Radosław Wicik On Gru 9, 2014, 12:49 rano, Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121389/ > ----------------------------------------------------------- > > (Updated Gru 9, 2014, 12:49 rano) > > > Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Radosław > Wicik, and Wojciech Kosowicz. > > > Bugs: 340768 > http://bugs.kde.org/show_bug.cgi?id=340768 > > > Repository: calligra > > > Description > ------- > > Newly created project shouldn't use window of previously opened project > > Unlike in 2.8 (https://git.reviewboard.kde.org/r/121321/) in case of server > projects > we're starting a new Kexi instance and pass connection data file to its > --connection option and database name. > In case of file projects we're passing absolute file path. > > As a side effect, a number of internal APIs improved: > - use const refs when reasonable > - keep relations between connection and its filename based on string key > instead of pointer (so deep copies are allowed) > - removed some unused routines > > > Diffs > ----- > > kexi/migration/importwizard.cpp 7dae2f639511d1cafb98da33cc3b5840acad3b1d > kexi/widget/KexiConnectionSelectorWidget.cpp > aeef8ba746fa7f015c2bf18965e134d1d973c597 > kexi/core/KexiRecentProjects.h a22a40ea071d5a78dd9aa710f3bf2d4518af0da9 > kexi/core/KexiRecentProjects.cpp eda7070d6f40589bf5b9a7f8d52cf4f4e58082ca > kexi/core/kexidbconnectionset.h 686355bff2a023e6df4d222eec80ecc47329858e > kexi/core/kexidbconnectionset.cpp a0616f0abbcca6d75e907a585cd19ead1022f1d3 > kexi/main/KexiMainWindow.h fa46b1215676ade8fafbdc3708bcf44aedb96d68 > kexi/main/KexiMainWindow.cpp e43d4d88857785aae7dec9a1e7be3a458d0da237 > kexi/main/startup/KexiNewProjectAssistant.h > 25b4705b303966e14c1e5db7cc3126d62cf2f5bf > kexi/main/startup/KexiNewProjectAssistant.cpp > 78a3e08c6248a18a2c1d150676fe0bcf1118846e > > Diff: https://git.reviewboard.kde.org/r/121389/diff/ > > > Testing > ------- > > Works OK for any combination of file/server projects > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
