> On April 21, 2015, 9:36 nachm., Boudewijn Rempt wrote: > > I suspect that this was originally meant when Jan wanted karbon to stroke > > paths with gimp brushes. Maybe first remove in 2.9?
Yes, patch is against 2.9. Waiting for yue to also perhaps comment, would commit April 23th otherwise. - Friedrich W. H. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123460/#review79309 ----------------------------------------------------------- On April 21, 2015, 9:29 nachm., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123460/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 9:29 nachm.) > > > Review request for Calligra, Yue Liu and Boudewijn Rempt. > > > Repository: calligra > > > Description > ------- > > Karbon has `s_instance->dirs()->addResourceType("kis_brushes", "data", > "krita/brushes/");`. Seems like that registration is there forever. But in > current code I cannot see how Karbon could make use of brushes. And at least > all code using such resource types is in krita/libbrush/kis_brush_server.cpp, > so should be also self-contained. > > Might have missed something, so asking the experts if this is really a bogus > registration. > > > Diffs > ----- > > karbon/ui/KarbonFactory.cpp 464bb0a > > Diff: https://git.reviewboard.kde.org/r/123460/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
