----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125649/#review86898 -----------------------------------------------------------
Ship it! Cannot test but looks good! How can we ensure it's ported to calligra master (3.0)? Otherwise we'd loose the fixes. - Jarosław Staniek On Oct. 15, 2015, 10:55 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125649/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2015, 10:55 p.m.) > > > Review request for Calligra and KDE Software on Mac OS X. > > > Repository: calligra > > > Description > ------- > > Builds on OS X currently generate icons for most Calligra applications, but > those are installed only for a happy few (Krita, Braindump and Kexi). The > other applications require an explicit install command of the generated > `.icns` file into the app bundle's Resources directory. > > The attached patch takes care of that. > > In addition, it corrects the picture source directories for calligragemini > and calligraauthor so those applications can have icons on other platforms > too, and replaces the `Q_WS_MACOS` token with the (IMHO) more appropriate > `APPLE` token. > > > Diffs > ----- > > flow/part/CMakeLists.txt 58882f1 > gemini/CMakeLists.txt 85123fa > karbon/CMakeLists.txt b574779 > plan/CMakeLists.txt ad39f57 > sheets/CMakeLists.txt b0cc134 > stage/app/CMakeLists.txt 079bece > words/app/CMakeLists.txt 1e73971 > words/part/CMakeLists.txt 9143176 > > Diff: https://git.reviewboard.kde.org/r/125649/diff/ > > > Testing > ------- > > On OS X 10.9 with KDELibs 4.14.12 and MacPorts 2.3.4 . > > > Thanks, > > René J.V. Bertin > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
