On 22 December 2015 at 00:48, Jaroslaw Staniek <stan...@kde.org> wrote: > On 20 December 2015 at 22:27, Friedrich W. H. Kossebau <kosse...@kde.org> > wrote: >> Am Sonntag, 20. Dezember 2015, 20:54:08 schrieb Jaroslaw Staniek: >>> On 20 December 2015 at 14:53, Friedrich W. H. Kossebau <kosse...@kde.org> >> wrote: >>> > Am Mittwoch, 16. Dezember 2015, 20:19:56 schrieb Jaroslaw Staniek: >>> > Curious (no own opinion), any plans to also restore the branches? Or do >>> > you >>> > consider that legacy info which can be lost? >>> >>> I don't see a reason. All the calligra/* branches stay in calligra.git. >>> Calligra.git history won't be edited, just kexi/ dir and related will >>> be removed using a commit. >>> This is not different to how krita moved and everyone else can. >> >> Ah, sure (guess I mixed up things with another unrelated project, pardon). >> >>> > Is the patch needed to make it build somewhere available, so I can give >>> > some build feedback on the state? >>> >>> Pushed to master now: >> >> Configures, builds, installs and starts here :) > > Thanks, next step, could you please review this commit (calligra.git > master) and try to build calligra with it? > > https://quickgit.kde.org/?p=clones/calligra/staniek/work.git&a=commit&h=f29b74b78aeecdf23dee9eef03301913f7edb907 >
These are findings from Friedrich, my comments inline. @Friedrich Thanks for detailed review. Resulting patch with new changes (you'll find some other removals too): https://paste.kde.org/pc6ufn1lb > why remove scripts in sheets/plugins/scripting/scripts? depends on sheets, > not kexi. kexidb*.py scripts depend on a no longer existing kexidb scripting module. In fact it should not exist in master as soon as we entered 3.0 stage. > removal from obsolete.txt is incomplete, and also loses that info bit,no? reverted the removal, let's keep it as is > commit message also better points out that only master is affected, branches > still keep older kexi variants done > please also remove no longer used > Find{CalligraPostgreSQL,CalligraSqlite,Pqxx,XBase}.cmake files (and FindFreeTDS.cmake) done > README & README.PACKAGERS need cleanage from Kexi as well done (for now), kexi.git will contain the removed Kexi bits TODO: (?) A bit later for README we may need to decide: does README describe Calligra or calligra.git. If the former, don't you think mentioning Krita and Kexi here (with a note where to grab them) makes sense? If the latter, we shall rephrase the file to mention it's a description of calligra.git. Then it still makes sense that there are other repos. -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database apps builder - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek _______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
