Steve Underwood wrote:
thomas schorpp wrote:
thomas schorpp wrote:
http://www.callweaver.org/ticket/344
1.2RC Revision: 4582
Silently failing calls with all peers still using payload type 2 for
G.726 codec and log flooding with
NOTICE[xxxxxxxxxx] rtp.c: Unknown RTP codec 2 received
will occur without -DUSE_DEPRECATED_G726 compiler defined CW builds.
Please discuss adding configure switch defaulting to YES for
-DUSE_DEPRECATED_G726. Tested OK here.
Any drawbacks?
y
tom
drawback #1: ekiga 2.0.11 sets up G.721 instead G.726 for payload type 2
if called.
That is not a drawback. G.721 is the same as G.726. This is the very
reason why the change is being asked for. Ekiga is broken, and follows
an ancient non-standard Cisco practice.
Steve
added configure switch for USE_DEPRECATED_G726. broken peers around.
patch attached.
but pls fix the error handling for SIP in calls with such peers, see above.
y
tom
Index: configure.ac
===================================================================
--- configure.ac (revision 4600)
+++ configure.ac (working copy)
@@ -801,13 +801,22 @@
dnl Enable SIP call limit. This is broken and should be fixed before release.
AC_ARG_ENABLE(sip-call-limit,
- [AC_HELP_STRING([--enable-sip-call-limit],[Enable broken SIP call limits (default=no)])],,[enable_sip_call_limit="no"])
+ [AC_HELP_STRING([--enable-sip-call-limit],[Enable broken SIP call limit (default=no)])],,[enable_sip_call_limit="no"])
if test "${enable_sip_call_limit}" = "yes"; then
AC_DEFINE([ENABLE_SIP_CALL_LIMIT],[],[Enable broken SIP call limit])
fi
AM_CONDITIONAL([ENABLE_SIP_CALL_LIMIT],[test "${enable_sip_call_limit}" = "yes"])
+dnl Enable Cisco-style RTP payload type 2 handling for G.726 . This is a RFC violation for broken peers. Silence Bug should be fixed.
+AC_ARG_ENABLE(rtp-payload-2,
+ [AC_HELP_STRING([--enable-rtp-payload-2],[Enable Cisco-style RTP payload type 2 (default=no)])],,[enable-rtp-payload-2="no"])
+
+if test "${enable-rtp-payload-2}" = "yes"; then
+ AC_DEFINE([USE_DEPRECATED_G726],[],[Enable Cisco-style RTP payload type 2])
+fi
+AM_CONDITIONAL([USE_DEPRECATED_G726],[test "${enable-rtp-payload-2}" = "yes"])
+
dnl Enable debugging
AC_ARG_ENABLE(debug,
[AC_HELP_STRING([--enable-debug],[build with debug information])],,[enable_debug="no"])
_______________________________________________
Callweaver-dev mailing list
Callweaver-dev@callweaver.org
http://lists.callweaver.org/mailman/listinfo/callweaver-dev
