svn commit: r670544 - /activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/model/ChoiceType.java

[gertv]

Author: gertv
Date: Mon Jun 23 05:34:40 2008
New Revision: 670544

URL: http://svn.apache.org/viewvc?rev=670544&view=rev
Log:
CAMEL-612: Add WARN log entry for ChoiceType without OtherwiseType

Modified:
    
activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/model/ChoiceType.java

Modified: 
activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/model/ChoiceType.java
URL: 
http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/model/ChoiceType.java?rev=670544&r1=670543&r2=670544&view=diff
==============================================================================
--- 
activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/model/ChoiceType.java
 (original)
+++ 
activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/model/ChoiceType.java
 Mon Jun 23 05:34:40 2008
@@ -29,10 +29,13 @@
 import org.apache.camel.Predicate;
 import org.apache.camel.Processor;
 import org.apache.camel.builder.ExpressionClause;
+import org.apache.camel.impl.converter.DefaultTypeConverter;
 import org.apache.camel.processor.ChoiceProcessor;
 import org.apache.camel.processor.FilterProcessor;
 import org.apache.camel.spi.RouteContext;
 import org.apache.camel.util.CollectionStringBuffer;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 /**
  * Represents an XML <choice/> element
@@ -42,6 +45,9 @@
 @XmlRootElement(name = "choice")
 @XmlAccessorType(XmlAccessType.FIELD)
 public class ChoiceType extends ProcessorType<ChoiceType> {
+    
+    private static final transient Log LOG = 
LogFactory.getLog(ChoiceType.class);
+    
     @XmlElementRef
     private List<WhenType> whenClauses = new ArrayList<WhenType>();
     @XmlElement(required = false)
@@ -66,6 +72,8 @@
         Processor otherwiseProcessor = null;
         if (otherwise != null) {
             otherwiseProcessor = otherwise.createProcessor(routeContext);
+        } else {
+            LOG.warn("No otherwise clause was specified for a choice block -- 
any unmatched exchanges will be dropped");
         }
         return new ChoiceProcessor(filters, otherwiseProcessor);
     }