[ 
https://issues.apache.org/activemq/browse/CAMEL-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=40990#action_40990
 ] 

Claus Ibsen commented on CAMEL-283:
-----------------------------------

And a sample of the logging I have tested with:

2008-01-05 15:00:41,140 [enerContainer-2] ERROR 
org.apache.camel.processor.DeadLetterChannel - Failed delivery for exchangeId: 
ID-claus-acer/2575-1199541640390/0-9. On delivery attempt: 0 caught: 
java.lang.IllegalArgumentException: Hey I forced this exception to test 
something

2008-01-05 15:00:42,187 [enerContainer-2] ERROR 
org.apache.camel.processor.DeadLetterChannel - Failed delivery for exchangeId: 
ID-claus-acer/2575-1199541640390/0-9. On delivery attempt: 1 caught: 
java.lang.IllegalArgumentException: Hey I forced this exception to test 
something

And now the new log line where we can see that its moved to the ActiveMQ 
deadletter channel

2008-01-05 15:00:42,218 [enerContainer-2] ERROR 
org.apache.camel.processor.DeadLetterChannel - Failed delivery for exchangeId: 
ID-claus-acer/2575-1199541640390/0-9. Handled by the failure processor: 
sendTo(Endpoint[activemq:queue:dead])


> DeadLetterChannel - logging improvements when exchange handled by dead letter
> -----------------------------------------------------------------------------
>
>                 Key: CAMEL-283
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-283
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.2.0
>            Reporter: Claus Ibsen
>            Priority: Trivial
>         Attachments: camel_283_patch.txt
>
>
> The submitted patch have these improvements to the logger in 
> deadletterchannel for delivery attempts
> - outputs exchange id so we can correlate the lines in the log files.
> - now also logs when the exchange could not be delivered and was handled by 
> the failure processer (usually a deadletterchannel)
> - minor issues with existing debug logging when sleeping (now also output 
> millis) to be in line with other similar log lines in Camel
> I have not outputted the exchange itself (exchange.toString()) when the 
> delivery could not be delivered successfully since there could be sensitive 
> data in the exchange (e.g. an invoice input message) that we do not want to 
> be logged in our log.
> But I think the logging of the exchange id is a good improvement and that 
> they are aligned in the same position in the logline so it's easier to 
> grep/find in the logs when you investigate and incident.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to