[
https://issues.apache.org/activemq/browse/CAMEL-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42333#action_42333
]
Claus Ibsen commented on CAMEL-298:
-----------------------------------
Hadrian
I do not think CachingInjector is a class that is used much by end users
directly, isn't it mere an internal helper for the annotation styled type
converters: AnnotationTypeConverterLoader?
I do not think breaking API should be of much concern in this situation
I do think we should either:
a) do as Christian suggests move it to the converter.impl sub package where its
an internal helper for the annotations stuff only
b') or move it to a generic util package such as org.apache.camel.util to let
it be usable in other areas in Camel? Also when its in the package the API
suggests that please use me. And thus now we should be more careful with API
breakings.
c) We could mark the original class as @deprecated and do either a or b
Any thoughts?
> Remove tangle between impl and impl.converter
> ---------------------------------------------
>
> Key: CAMEL-298
> URL: https://issues.apache.org/activemq/browse/CAMEL-298
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Christian Schneider
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
> Attachments: after patch no tangle.png, before patch.png
>
>
> Currently impl and impl.converter reference each other. If possible such
> cycles should be avoided.
> When I looked into it I found that impl.converter references only a single
> class CachingInjector. No other class in camel-core seems to use this class.
> So my suggestion is to move CachingInjector to impl.converter. So the cycle i
> removed. As far as I can see this should cause no ther issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
