Hi Claus,
I do not like the eclipse's auto formate for the long lines either.
But with help of Checkstyle plugin, I still get help for writing a
better formate code, special for the ASF header checking.
BTW
I will commit a buildingtools module to help the Maven Checkstyle plugin
to apply the rule and exculde the files (the generated codes etc) which
we do not want to validate with Checkstyle.
When you run the mvn install -Psourcecheck (this profile will not be
active by default) you will build the code with the Checkstyle
validation first.
If every one is OK for the building code with Checkstyle validation
first , I will set the profile to be default active profile.
Willem
Claus Ibsen wrote:
I will like to change my vote to -1
It is a must for me that the line breaks does not stays at 80.
Even better checkstyle should not change line breaks at all. A human is much
better at aligning the lines in normal and special cases.
I have seen toons of code where it would indent a string concat to a new line
with heaps of spaces, eg
Logger.debug("This is a long string outputting something and its breaked" +
myobject);
Would then become
Logger.debug(
"This is a long string outputting something and its breaked" +
myobject)
And it should work out-of-the-box with Maven so it can generate a report.
Using this we are not dependent on either IDEA or Eclipse. And the checkstyle
rules should be a file that we have checked in SVN so the plugins in Eclipse or
IDEA can use this rule file.
Med venlig hilsen
Claus Ibsen
......................................
Silverbullet
Skovsgårdsvænget 21
8362 Hørning
Tlf. +45 2962 7576
Web: www.silverbullet.dk
-----Original Message-----
From: James Strachan [mailto:[EMAIL PROTECTED]
Sent: 30. april 2008 12:04
To: [email protected]
Subject: Re: Building the code with the CheckStyle
I've suffered heaps of pain with servicemix and cxf as often the
checkstyle rules only work with eclipse and I use IntelliJ
So I'd be -1 from making these mandatory - until we figure out an easy
way to configure *both* eclipse and IntelliJ.
Also I'm with Claus on the 80 character limitation which is from a few
decades ago. 160 is fine :)
2008/4/30 Willem Jiang <[EMAIL PROTECTED]>:
Hi Team,
I'd like to enable the CheckStyle when build the camel code.
There are lots of benefits which we can get from CheckStyle:
1.Finding out if we are missing the ASF header in the java file.
2 Making our codes more consistent ( not including any tab character which
will cause bad formate).
3.Excluding the useless import package.
...
All you have to do is install the CheckStyle pluging in Eclipse , and it
should be same with the Intellij :)
Any thought?
Willem
