[
https://issues.apache.org/activemq/browse/CAMEL-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44237#action_44237
]
Vadim Chekan commented on CAMEL-659:
------------------------------------
Nice job Michael,
I have a question about the fragment:
- if (shouldOutputHeader(exchange, name, value)) {
+ // BUG?
+ if (value != null && shouldOutputHeader(exchange, name, value)) {
Does it cause errors having a header without value? I can imagine situation
when it matters just the fact that header is in the message and there is no
need to put any value into it. Or indication of empty set.
> XMPP endpoint should should auto-reconnect if it loses connection to the xmpp
> server
> ------------------------------------------------------------------------------------
>
> Key: CAMEL-659
> URL: https://issues.apache.org/activemq/browse/CAMEL-659
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-xmpp
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Michael Kahn
> Fix For: 1.5.0
>
> Attachments: camel-xmpp-smack_3_0_4.patch
>
>
> In 1.3.0, XmppEndpoint.java and related classes use the smack 2.2.1 API, and
> have a getConnection() method that sets up and caches the xmpp connection and
> chat once when the endpoint is initialized. If the network connection to the
> xmpp server is subsequently lost, attempts to route throw an exception. This
> makes use of this component on remote and roaming/wireless devices difficult.
> Smack API 3.0.4+ (the only version available for "official" download right
> now) should auto-reconnect the XMPPConnection once it is created, reusing the
> same credentials from the current login() session, however the API is not a
> drop-in replacement, there are a few differences. It also isn't in the maven
> repository yet - that maxes out at 2.2.1.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
