[
https://issues.apache.org/activemq/browse/CAMEL-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vadim Chekan updated CAMEL-757:
-------------------------------
Attachment: diff.txt
Comments for the patch:
Added support of MultiUserChat to XmppConsumer. I opted to add it into
XmppConsumer instead of creating a separate XmppMultiUserchatConsumer because
when I did it, it turned out to be two identical classes with slight
differences.
Bug fix.
XmppConsumer listened to "raw" xmpp packages filtering and processing those of
type "Message". Because of low-level nature of packages XmppConsumer failed to
check either the type of message is "error" or "response" so unit test passed
successfully because XmppComponent thought that message has been received when
in fact echo with error message has been sent by server.
I fixed it by removing listener to the raw xmpp connection packages and
utilizing smack.Chat class which does all error detecting and other low level
functions. It allowed to remove some extra code from XmppConsumer.processPacket
too.
XmppEndpoint
As soon as nobody listens to the raw packages, no need to have PacketFilter
property anymore.
Added conference subdomain detection code (CAMEL-748 can be closed if patch is
accepted)
GroupChat Producer and Consumer: added attribute to suppress history messages
to be sent upon room joining.
Unit test:
Had some problems with accounts kicking out each other when log in or join
room. Solved by introducing 3 different resources/nicknames for a single
account.
> Add room support in consumer mode
> ---------------------------------
>
> Key: CAMEL-757
> URL: https://issues.apache.org/activemq/browse/CAMEL-757
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-xmpp
> Affects Versions: 1.4.0
> Reporter: Vadim Chekan
> Priority: Minor
> Fix For: 1.5.0
>
> Attachments: diff.txt
>
>
> Currently XmppEndpoint support room only for producer but not for consumer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
