Sure, I'm working on this, it should be done after I run a quick test. Willem
On Sat, Nov 22, 2008 at 9:53 PM, Claus Ibsen <[EMAIL PROTECTED]> wrote: > Hi William > > Great could you do it on the 1.x branch as well? > > /Claus Ibsen > Apache Camel Committer > Blog: http://davsclaus.blogspot.com/ > > > > On Sat, Nov 22, 2008 at 2:22 PM, Willem Jiang <[EMAIL PROTECTED]> > wrote: > > Hi Claus, > > > > I just fixed these CS Errors, if you don't mind I will commit the fix > > patch in a minute :) > > > > Willem > > > > Claus Ibsen wrote: > >> Hi > >> > >> I have refactored the code so the responsebody is a constructor > >> parameter so it can be final. > >> > >> And I will fix the other checkstyle errors of missing apache licenses. > >> Sorry IDEA hides these ;) > >> > >> /Claus Ibsen > >> Apache Camel Committer > >> Blog: http://davsclaus.blogspot.com/ > >> > >> > >> > >> On Sat, Nov 22, 2008 at 11:30 AM, Claus Ibsen <[EMAIL PROTECTED]> > wrote: > >>> Hi > >>> > >>> Checkstyle has been enabled when doing maven install and now I have a > >>> catch-22 situation. > >>> > >>> It want's that a field in HttpOperationFailedException should be > >>> declared final but it can not, as it's optional and there is a setter > >>> for it. > >>> > >>> [INFO] Starting audit... > >>> > D:\project\camel\components\camel-http\src\main\java\org\apache\camel\component\http\HttpOperationFailedException.java:29:5: > >>> The field 'responseBody' must be declared final. > >>> Audit done. > >>> > >>> /Claus Ibsen > >>> Apache Camel Committer > >>> Blog: http://davsclaus.blogspot.com/ > >>> > >> > > > > >
