[
https://issues.apache.org/activemq/browse/CAMEL-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48137#action_48137
]
Jonathan Anstey commented on CAMEL-1184:
----------------------------------------
Ah silly me, it was a logic error :) I made this change to your patch:
{code}
- if (dataObjectType.isAssignableFrom(String.class) ||
dataObjectType.isAssignableFrom(Node.class)) {
+ if (!dataObjectType.isAssignableFrom(String.class) &&
!dataObjectType.isAssignableFrom(Node.class)) {
throw new IllegalArgumentException("TidyMarkupDataFormat only
supports returning a String or a org.w3c.dom.Node object");
}
{code}
I applied your patch in revision 725883. Thanks Ramon!
> Add a new Dataformat - tidyMarkup - which allows us to unmarshal bad HTML to
> good (XML) Html.
> ---------------------------------------------------------------------------------------------
>
> Key: CAMEL-1184
> URL: https://issues.apache.org/activemq/browse/CAMEL-1184
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Ramon Buckland
> Assignee: Ramon Buckland
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: patchfile.txt, tidyMarkup-sourcefiles.tgz
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> Using TagSoup, a competent 'bad html' to good well formed (xml) Html, we can
> create a new dataformat such that ..
> from("direct:fromSomeHttpSite")
> .unmarshal().tidyMarkup()
> .setBody().xpath("//table/tr/td[1]")
> .to("direct:foo")
> we get to turn the nasty HTML into goody HTML which can go through XSLT
> components and be xpathed and all the goodness we love.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
