For just this reason, the hashtables in Core have been reimplemented to use an AVL tree in the buckets. That way, even when you have pathological collisions, you degrade gracefully to O(log n) per operation, instead of O(n), where n is the number of keys in the hashtable.
y On Fri, Dec 30, 2011 at 11:44 AM, Gerd Stolpmann <i...@gerd-stolpmann.de>wrote: > Hi, > > there was recently a security alert for web services that use hash > tables to store web form parameters sent via POST (so that millions of > such parameters can be sent in a single request). It is possible to keep > the web service busy for hours with such a DoS (denial of service) > attack. The type of attack boils down to a problem in most hash table > implementations, namely that the hash functions are invertible, and it > is possible for a malicious user to construct lots of keys that all map > to the same bucket of the hash table, creating a mass collision. > > The text of the alert: > http://www.nruns.com/_downloads/advisory28122011.pdf > > I'd like to discuss this issue, because it is not restricted to the > processing of web requests, but may also occur for all other data coming > from untrusted sources. The web is only the most exposed area where this > issue exists. > > So how is Ocaml affected? The hash functions used in recent Ocaml > releases are also insecure in the above mentioned sense (currently > MurmurHash3, and even a simpler hash function in previous releases). A > quick survey of the Internet revealed at least one site that tries to > break it. Probably a good cryptographer could do it in minutes. > > A pure Hashtbl.add of the constructed keys does not yet lead to the > performance degradation, but a Hashtbl.replace, and of course > Hashtbl.find after the table is built up will. So it depends very much > of the details of the programs whether they are affected or not. > > I've just checked that Ocamlnet uses only Hashtbl.add to collect POST > parameters, so it is not directly vulnerable. But if the crafted request > is actually served by a handler, the handler would get a degraded table, > and could show in turn bad performance (again leading to DoS). > > What are possible fixes? > > 1) Avoid hash tables in contexts where security is relevant. The > alternative is Set (actually a balanced binary tree), which does not > show this problem. > > 2) Use cryptographically secure hash functions. > > 3) Use "randomized" hash tables. The trick here is that there is not a > single hash function h anymore, but a family h(1)...h(n). When the hash > table is created, one of the functions is picked randomly. This makes it > impossible to craft an attack request, because you cannot predict the > function. > > I don't think 1) is viable - hash tables are too wide spread, and are > loved by programmers because of their good performance. 2) would be good > in extremely critical contexts - although it is then again questionable, > because it is likely to have worse performance than 1). > > So, the question is how to do 3). I see two problems here: > > a) how to define the family of hash functions. Is it e.g. sufficient to > introduce an initialization vector for the Murmurhash algorithm, and > fill it randomly? How to get a random number that is good enough? > > b) the Hashtbl in the standard library does not allow it to set the hash > function dynamically. Maybe one can get this effect by using first-class > modules (haven't checked). > > Anyway, I think these problems are difficult enough to deserve some > discussion here. At least I cannot solve them immediately, and this > problem may exist for lots of Ocaml applications. > > Gerd > -- > ------------------------------------------------------------ > Gerd Stolpmann, Darmstadt, Germany g...@gerd-stolpmann.de > Creator of GODI and camlcity.org. > Contact details: http://www.camlcity.org/contact.html > Company homepage: http://www.gerd-stolpmann.de > ------------------------------------------------------------ > > > -- > Caml-list mailing list. Subscription management and archives: > https://sympa-roc.inria.fr/wws/info/caml-list > Beginner's list: http://groups.yahoo.com/group/ocaml_beginners > Bug reports: http://caml.inria.fr/bin/caml-bugs > > -- Caml-list mailing list. Subscription management and archives: https://sympa-roc.inria.fr/wws/info/caml-list Beginner's list: http://groups.yahoo.com/group/ocaml_beginners Bug reports: http://caml.inria.fr/bin/caml-bugs