Cool. As Tamás pointed out, there's at least one more data race (which I'm working on) though. hang on.
On 3 May 2016 at 12:45, jason gessner <[email protected]> wrote: > sorry, i wasn't actually on the 0.9 release. I was in a git checkout. > > Head at that point was > > commit a1ec9bf60ea42f111b95e0d4ee8602e73e78b984 > Author: Will Norris <[email protected]> > Date: Wed Apr 27 12:10:10 2016 -0700 > > rename HACKING to CONTRIBUTING.md > > GitHub treats the CONTRIBUTING file special, in that it is referenced > any time someone files a new issue or starts to create a pull request. > Also make minor updates to file to use markdown and current hacking > instructions. > > I am now at > commit 2ed2b175a23a98736439bad1ccc79c7dd1dacc9b > Merge: 1fcacd8 d2818d5 > Author: Mathieu Lonjaret <[email protected]> > Date: Tue May 3 15:08:13 2016 +0000 > > Merge "pkg/search: RLock index around GetBlobMeta" > > and all appears well. Sorry for the mistake on which version on i was in! > > -jason > > On Tue, May 3, 2016 at 1:15 AM Mathieu Lonjaret <[email protected]> > wrote: >> >> which would contradict the fact that the bug was introduced at rev >> e93e4f3822aaa6946f19c6d2d8dd949c2edece9e , since you're saying you hit >> the bug with the 0.9 release code. >> >> >> >> On 3 May 2016 at 01:10, Mathieu Lonjaret <[email protected]> >> wrote: >> > Also, it looks like you might be hitting the same as reported in >> > https://github.com/camlistore/camlistore/issues/750 >> > >> > >> > On 3 May 2016 at 00:50, Mathieu Lonjaret <[email protected]> >> > wrote: >> >> Hi, >> >> >> >> I can't reproduce. Camlistore 0.9 with go 1.6.2 on Linux. Although I >> >> tried with devcam out of laziness, so at least the indexer choice >> >> might make a difference with your configuration. >> >> Could you please: >> >> 1) paste your ~/.config/camlistore/server-config.json file (beware in >> >> whatever credentials you have in there) >> >> 2) retry with Camlistore at tip? Even if we can reproduce/explain your >> >> bug, we can't fix it for 0.9 anyway, so we'll have to fix it for 0.10. >> >> >> >> Thanks, >> >> Mathieu >> >> >> >> >> >> On 2 May 2016 at 10:19, jason gessner <[email protected]> wrote: >> >>> Hello! >> >>> >> >>> I just pulled down and built a fresh copy of go 1.6.2 on my os x 10.11 >> >>> machine with the camlistore 0.9 release code. >> >>> >> >>> When i build and run the camlistore server and start an importer (i >> >>> tried >> >>> with flickr and twitter and the results were the same), camlistored >> >>> dies >> >>> with: >> >>> >> >>> fatal error: concurrent map read and map write >> >>> >> >>> goroutine 55 [running]: >> >>> runtime.throw(0xed8640, 0x21) >> >>> /Users/jgessner/src/go/src/runtime/panic.go:547 +0x90 fp=0xc820559c50 >> >>> sp=0xc820559c38 >> >>> runtime.mapaccess2(0xa07520, 0xc8208230e0, 0xc820559e30, 0xc823015bf8, >> >>> 0x186c901) >> >>> /Users/jgessner/src/go/src/runtime/hashmap.go:343 +0x5a >> >>> fp=0xc820559c98 >> >>> sp=0xc820559c50 >> >>> camlistore.org/pkg/index.(*Index).GetBlobMeta(0xc8200786c0, 0x18c09b8, >> >>> 0xc82000aec8, 0x18cc990, 0xc82297c6e0, 0x0, 0x0, 0x0, 0x0, 0x0, ...) >> >>> >> >>> /Users/jgessner/sandbox/camlistore/tmp/build-gopath-nosqlite/src/camlistore.org/pkg/index/index.go:781 >> >>> +0x123 fp=0xc820559ea8 sp=0xc820559c98 >> >>> >> >>> camlistore.org/pkg/search.(*Handler).subscribeToNewBlobs.func1(0xc8209e2720, >> >>> 0xc820823020) >> >>> >> >>> /Users/jgessner/sandbox/camlistore/tmp/build-gopath-nosqlite/src/camlistore.org/pkg/search/handler.go:98 >> >>> +0x156 fp=0xc820559fb0 sp=0xc820559ea8 >> >>> runtime.goexit() >> >>> /Users/jgessner/src/go/src/runtime/asm_amd64.s:1998 +0x1 >> >>> fp=0xc820559fb8 >> >>> sp=0xc820559fb0 >> >>> created by camlistore.org/pkg/search.(*Handler).subscribeToNewBlobs >> >>> >> >>> /Users/jgessner/sandbox/camlistore/tmp/build-gopath-nosqlite/src/camlistore.org/pkg/search/handler.go:103 >> >>> +0xc2 >> >>> >> >>> along with a ton of other goroutines. I took a quick look last week >> >>> and >> >>> didn't see any bugs filed for this, but i didn't look super, super >> >>> hard. >> >>> >> >>> -jason >> >>> >> >>> -- >> >>> You received this message because you are subscribed to the Google >> >>> Groups >> >>> "Camlistore" group. >> >>> To unsubscribe from this group and stop receiving emails from it, send >> >>> an >> >>> email to [email protected]. >> >>> For more options, visit https://groups.google.com/d/optout. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Camlistore" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "Camlistore" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Camlistore" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
