Thanks for the question, I wouldn't have noticed https://camlistore-review.googlesource.com/#/c/9146/ otherwise! Well at least not until later, as it was a conjunction of two different CLs that introduced the breakage.
On 17 January 2017 at 18:28, Attila Tajti <[email protected]> wrote: > I tried publisher the first time today, and it worked fine after adding > just > > "publish": { > "/pics/": { > "camliRoot": "mypics", > "cacheRoot": "/home/ata/var/camlistore/blobs/cache", > "goTemplate": "gallery.html" > } > } > > to the server-config, and I could access «camlihost:port»/pics/ just fine. > However after updating camlistore it is broken. The CL/issue > > https://camlistore-review.googlesource.com/#/c/8866/ > https://github.com/camlistore/camlistore/issues/882 > > seems to be the culprit, I can access «camlihost:port»/pics/ with > d864e3580281c26ff3507d1df60f8d2542ee1c2c but not with master ( > abc6561c60c863589bb146784e70432806c14d4d). > Yes, that is the point of the CL. It is a debatable decision, but I found that I wouldn't usually let the world know of all my published stuff at the same time. I usually want to share a particular item, or set of items, with an audience, not unveil everything that I have. It is of course not a security measure by any means, as everything is still published and discoverable with enough effort, but it's more of an attempt at basic privacy. > Since I have no experience with publisher, my question if one should > publish image permanodes or sets with children? I've checked the CL and the > issue, and the issue mentions how one should be able to access > "subdirectories" under /pics/. Should the URL ("foo" and "bar" in the > example in the issue) be set through camliPath, camliMember/title? > The camliRoot itself only supports camilPath, so foo and bar are camliPath attributes set on the camliRoot, such as: camilPath:foo = sha1-foo camliPath:bar = sha1-bar sha1-foo (and sha1-bar) should be either a permanode with some camliContent, or a permanode with some camliMembers. But I notice that a permanode with camliContent (directly at the root) seems to be broken. I'll look into it. You can then of course have anything deeper in the path (the camliMembers of sha1-foo can have camliMembers themselves, or have a camliContent file, or directory, etc.), but only sets (camliMembers) are browsable. directories (static-sets) aren't yet browsable, because we need to finish https://camlistore-review.googlesource.com/8326 first. > Btw, the thumbnails in the publisher show up with an incorrect aspect > ratio (apparently the image is streched into a square shape) but standalone > images appear fine. Is there anything I can do about it? > Yeah, I did the very minimum amount of math for the thumbs. You can: 1) as usual file an issue :-) (but that probably won't be in my priorities, sorry) 2) fix the code at app/publisher/js/members.go. Aaron had done it pretty well for the web UI (I'm still seeing some bugs if I mix images with very different sizes though), so that might be the way to go for inspiration. hth, Mathieu > -- > You received this message because you are subscribed to the Google Groups > "Camlistore" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Camlistore" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
