Yeah, the scanningcabinet app predated the best practices. We should fix it.


On Wed, Jan 3, 2018 at 9:35 AM, Angel <[email protected]> wrote:

> I see. So technically, the scanningcabinet app should actually be adding
> {"scanningcabinet:document": "sha1-parent"} to the "scan" permanode to keep
> attribute keys namespaced as well as values.
>
> On Wednesday, January 3, 2018 at 12:23:25 PM UTC-5, Brad Fitzpatrick wrote:
>>
>> Best practice is to prefix custom attributes with a domain name, like:
>>
>> https://github.com/camlistore/camlistore/blob/master/pkg/imp
>> orter/foursquare/foursquare.go
>>
>> (search for "foursquare.com:")
>>
>>
>> On Wed, Jan 3, 2018 at 9:15 AM, Angel <[email protected]> wrote:
>>
>>> Hello,
>>>
>>> I have a few ideas for apps I'd like to see on Perkeep but I'm wondering
>>> what the best practice is for apps adding attributes to permanodes. Is
>>> there any risk of one app relying on certain attributes for some business
>>> logic that may be added by another app? i.e. I noticed the scanningcabinet
>>> app, as part of its business logic, adds a "document" attribute to "scan"
>>> permanodes when several scans are combined. Another app could be developed
>>> that would re-use or add values to the "document" attribute without
>>> realizing the scanningcabinet app makes use of it.
>>>
>>> I know all attributes are technically "multi-valued" per their
>>> implementation so perhaps this isn't an issue. But I wanted to check if
>>> there were recommended best practices around custom apps namespacing
>>> attributes they add to permanodes or something like that.
>>>
>>> Thanks!
>>> Angel
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Camlistore" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to [email protected].
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>> --
> You received this message because you are subscribed to the Google Groups
> "Camlistore" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Camlistore" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to