I'm confused. Are you talking about what is now:

domainNames = []string{"perkeep.org", "camlistore.org"}

in website/godoc.go?

(it became domainNames in 02938281318c8dc1fdb0e7a46b543fb7e583a854)

As far as i can tell, we need the domain to:

1) verify that we're serving only for one of these two domains (which
might be overkill, as i think we already filter for that before
reaching this point)
2) being able to strip it out of the path, and derive the part of the
import path that is a "filepath" (as opposed to a domain name).

I think we're inheriting this second point from the logic of the go
stdlib godoc, since we copied the code from there and adapted it for
our needs afair.

Does that answer your question?



On 5 January 2018 at 23:01, Will Norris <w...@willnorris.com> wrote:
> Mathieu,
>
> Do you recall the reason for caring about the domain name appearing in the
> filepath in website/godoc.org?  It looks like it was added in a96ec4e, but I
> can't figure out why it's needed.  I'm working on trying to implement #1010,
> and was seeing what in website/godoc.go could be simplified or cleaned up as
> part of the process.

-- 
You received this message because you are subscribed to the Google Groups 
"Camlistore" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to camlistore+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to