My experience with javascript is rather limited, so I just searched the UI code for sha1 and added sha224 where it seemed absolutely necessary. I haven't looked into the issue other than that.
I just wanted to make my geotagging CL work on top of master. The offending commit is 38f10a7bd0f97475c2b876a7fde08e4ce47bf224 by the way: all, testhooks: use sha224 by default, add hook for some tests to use sha-1 Apparently, there are no tests for switching to a new hash yet. Maybe we should just switch back to SHA-1 as the default for the time being, or let the user choose the default hash. Btw, I haven't found much info on the sha224 shift yet (other than stumbling upon the commit in question). The related issue https://github.com/perkeep/perkeep/issues/537 was originally about SHA-3, now it's SHA-2. I don't know much about crypto, but the Wikipedia page on SHA-2 mentions SHA512/224 might be a better choice. On Wednesday, January 17, 2018 at 4:00:26 PM UTC+1, Eric Drechsel wrote: > > Actually, realized Atilla is already WIP on this with that CL, don't want > to duplicate work > > On Wed, Jan 17, 2018 at 6:44 AM, Eric Drechsel <[email protected] > <javascript:>> wrote: > >> Ok, I can take a look >> >> On Jan 17, 2018 6:43 AM, "Pau Fernández" <[email protected] <javascript:>> >> wrote: >> >>> I can confirm this. I am new to Perkeep and installed it a few days ago. >>> If you add pictures with the WebUI works fine, but not with "camput". >>> I switched to version 0.9 because of this. >>> >>> P >>> >>> On Wednesday, 17 January 2018 12:57:43 UTC+1, Attila Tajti wrote: >>>> >>>> I've noticed the Web UI doesn't work with sha224 blobs properly. >>>> >>>> Clicking the refs doesn't show anything, it changes window.location >>>> only. >>>> >>>> The changes in my CL[1] seemed to fix this issue for me, but I haven't >>>> checked it with both sha1 and sha224 blobs yet. >>>> >>>> [1] https://camlistore-review.googlesource.com/c/camlistore/+/13566 >>>> >>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Camlistore" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected] <javascript:>. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Camlistore" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > best, Eric > eric.pdxhub.org <http://pdxhub.org/people/eric> > > -- You received this message because you are subscribed to the Google Groups "Camlistore" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
