I am a Windows guy. I provided the same feedback in the review, it looks fine to me, but I don't have the context. Did you write some tests for it? I would recommend that.
Mike. On Thu, 15 Mar 2018 at 12:36 Mathieu Lonjaret <[email protected]> wrote: > Hi, > > If anyone familiar with Windows (Attila?) is willing to give a hand in > reviewing https://review.gerrithub.io/403981 , I'd appreciate it. > > Thanks, > Mathieu > > > > -- > You received this message because you are subscribed to the Google Groups > "Perkeep" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Thanks! Mike Lloyd USMC 808-633-8998 -- You received this message because you are subscribed to the Google Groups "Camlistore" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
