On Sun, May 25, 2008 at 4:25 PM, Julian Tarkhanov <[EMAIL PROTECTED]> wrote: > > On 25 mei 2008, at 00:25, Magnus Holm wrote: > >> * <insert your wish> > > * Are deeply nested query arguments and tricky bits like checkbox > arrays/param arrays handled properly (and in a Camping-compatible manner, > AFAIK in Camping > the first parameter wins as opposed to Rails) by Rack?
Rack doesn't do anything special with queries ending in [] and [key], so we're cleaning it up in Base#initialize. It works with arrays and hashes, but not perfectly when they're nested. Could you write some examples of how they should be handled? Here's a helper to see what Camping does today: http://pastie.caboo.se/private/53towf4gox3di0k6c8zhw I think we could use almost the same code if we just move it out to a helper and do some recursive magic. >What happens with file uploads? No idea! Maybe Christian Neukirchen can answer what Rack::Request does with it? There isn't any file-upload specific code in Camping now. > * I loved Camping::H too much, don't see a big deal in wrappint the > request/env hashes into it (also to avoid substantial code scavenging) It would be easier to remove Camping::H for good, but I like #method_missing for getting out the values... Unless we want to get it under the 3kB-mark, I don't think it's worth to remove it. We're far away from 4kB! > _______________________________________________ > Camping-list mailing list > Camping-list@rubyforge.org > http://rubyforge.org/mailman/listinfo/camping-list > -- Magnus Holm _______________________________________________ Camping-list mailing list Camping-list@rubyforge.org http://rubyforge.org/mailman/listinfo/camping-list
