Review: Approve One thing you might want to consider as an alternative to destroying the git tree and re-cloning it every time, is what we do in a lot of the other test jobs. Something like this: ``` git -C cc-tool-box pull -q || (rm -rf cc-tool-box && git clone -q https://git.launchpad.net/<...rest of url here>) ``` Basically this just pulls the thing in the directory, or if there's some error with pulling it, *then* it removes it and re-clones it. This can save a LOT of time, especially when you have multiple git repos.
Otherwise, this looks good, so +1 other than the optional optimization I mentioned above -- https://code.launchpad.net/~kevinyeh/hwcert-jenkins-jobs/+git/hwcert-jenkins-jobs/+merge/428245 Your team hwcert-jenkins is subscribed to branch hwcert-jenkins-jobs:master. -- Mailing list: https://launchpad.net/~canonical-hw-cert Post to : [email protected] Unsubscribe : https://launchpad.net/~canonical-hw-cert More help : https://help.launchpad.net/ListHelp
