Rod Smith has proposed merging ~rodsmith/maas-cert-server:improve-optimize-network into maas-cert-server:main.
Commit message: Update optimize-network script to not fail if a sub-command fails. Requested reviews: Michael Reed (mreed8855) For more details, see: https://code.launchpad.net/~rodsmith/maas-cert-server/+git/maas-cert-server/+merge/483583 Sub-commands can fail because they aren't supported on a specific device, so an automatic failure when a sub-command fails means that the script won't complete. Instead of doing a "raise Exception()", print a warning so that the user knows a command failed (if they're paying attention). -- Your team hardware-certification-users is subscribed to branch maas-cert-server:main.
diff --git a/debian/changelog b/debian/changelog index d5e452a..7038c75 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +maas-cert-server (0.7.11-0ppa1) noble; urgency=medium + + * Updated optimize-network to not fail if a subcommand fails + (https://bugs.launchpad.net/maas-cert-server/+bug/1904246) + + -- Rod Smith <[email protected]> Fri, 28 Mar 2025 12:23:57 -0400 + maas-cert-server (0.7.10-0ppa1) jammy; urgency=medium * Copy setup-certlab instead of maniacs-setup diff --git a/usr/sbin/optimize-network b/usr/sbin/optimize-network index 9b9e7b7..66f9624 100755 --- a/usr/sbin/optimize-network +++ b/usr/sbin/optimize-network @@ -69,7 +69,7 @@ def run(command): if results.returncode: print(output.decode(sys.stderr.encoding)) - raise Exception(errors) + print("*** Error code returned from command; it may not have worked!") else: print(output.decode(sys.stdout.encoding))
-- Mailing list: https://launchpad.net/~canonical-hw-cert Post to : [email protected] Unsubscribe : https://launchpad.net/~canonical-hw-cert More help : https://help.launchpad.net/ListHelp
