Review: Needs Fixing A couple of small comments, otherwise looks good.
Diff comments: > diff --git a/jobs/snap-testing/projects/havana-dome.yaml > b/jobs/snap-testing/projects/havana-dome.yaml > new file mode 100644 > index 0000000..f7277b4 > --- /dev/null > +++ b/jobs/snap-testing/projects/havana-dome.yaml > @@ -0,0 +1,43 @@ > +- project: > + name: havana-dome > + queue: havana-dome > + email: [email protected] > + arch: arm64 > + store: dq8OtmyCoHLVDYf7Az55 > + checkbox_snap: checkbox-havana > + launcher: '' > + #provision_data: | > + # provision_data: > + # distro: core20-latest-stable You might want to consider having some fake provision data here to force a reboot if it's unreachable > + custom_launcher: > + !include-raw-escape: > jobs/snap-testing/launchers/havana-dome-automated > + #extra_setup_cmds: > + #declare -A snap_track_map > + # snap_track_map=( ["network-manager"]="20") Any reason to keep this since it's commented out? > + has-serial-assertion: False > + snap_reset_needed: True > + track: latest > + user: ubuntu > + test_data: | > + # user and password for havana-dome > + test_username: ubuntu > + test_password: ubuntu > + checkbox_track: latest > + checkbox_channel: edge > + checkbox_conf: > + !include-raw-escape: > jobs/snap-testing/configs/checkbox.conf.havana-dome > + manifest: > + !include-raw-escape: > jobs/snap-testing/manifests/havana-dome_manifest.conf > + jobs: > + - '{prefix}-{name}-{snap}-{channel}': > + snap: checkbox-havana > + channel: edge > + extra_args: --devmode > + - '{prefix}-{name}-{snap}-{channel}': > + snap: checkbox20 > + - '{prefix}-{name}-{snap}-{channel}': > + snap: core20 > + - '{prefix}-{name}-{snap}-{track}-{channel}': > + snap: hon-hbt-cv22-kernel > + - '{prefix}-{name}-{snap}-{channel}': > + snap: snapd -- https://code.launchpad.net/~kevinyeh/hwcert-jenkins-jobs/+git/hwcert-jenkins-jobs/+merge/434985 Your team hwcert-jenkins is subscribed to branch hwcert-jenkins-jobs:master. -- Mailing list: https://launchpad.net/~canonical-hw-cert Post to : [email protected] Unsubscribe : https://launchpad.net/~canonical-hw-cert More help : https://help.launchpad.net/ListHelp
