Review: Approve
Looks good, and sounds like that might help, though it's hard to imagine how we
really have a problem with those updates happening frequently across multiple
job types. Let's see how it goes. Thanks!
Diff comments:
> diff --git a/jobs/image-testing/run-image-testing-server.sh
> b/jobs/image-testing/run-image-testing-server.sh
> index f0e04b2..547f6a9 100755
> --- a/jobs/image-testing/run-image-testing-server.sh
> +++ b/jobs/image-testing/run-image-testing-server.sh
> @@ -197,6 +197,6 @@ if [ -f artifacts/submission.json ]; then
> cat artifacts/submission.json |jq -r '. | {{results: .results}}' >
> results.json
> curl -s
> "https://testflinger-revcache.canonical.com/v1/results/$JOB_NAME"; -X POST
> --header "Content-Type: application/json" --data @results.json
> fi
> -flock /tmp/TRELLO-IMAGE-UPDATE.LOCK
> certification-dashboard-manager.dashboard-manager --app trello imageupdater
> -n {name} -i {image_file} -c {image_channel} -v $BUILD_ID --summaryfile
> artifacts/summary
> +flock /tmp/TRELLO-UPDATE.LOCK
> certification-dashboard-manager.dashboard-manager --app trello imageupdater
> -n {name} -i {image_file} -c {image_channel} -v $BUILD_ID --summaryfile
> artifacts/summary
Yes, but without the underscores. We use flock on /tmp/TRELLO-UPDATE.LOCK to
ensure only one runs at a time. They run very fast, so there's not a big risk
of long lock contention.
> echo "Test exit status: $TEST_STATUS"
> exit $EXITCODE
--
https://code.launchpad.net/~jocave/hwcert-jenkins-jobs/+git/hwcert-jenkins-jobs/+merge/436237
Your team hwcert-jenkins is subscribed to branch hwcert-jenkins-jobs:master.
--
Mailing list: https://launchpad.net/~canonical-hw-cert
Post to : [email protected]
Unsubscribe : https://launchpad.net/~canonical-hw-cert
More help : https://help.launchpad.net/ListHelp
