Review: Needs Fixing
Please see my inline comment and fix those problems.
Diff comments:
> diff --git a/jobs/sru/projects/202201-29911.yaml
> b/jobs/sru/projects/202201-29911.yaml
> new file mode 100644
> index 0000000..ba052cc
> --- /dev/null
> +++ b/jobs/sru/projects/202201-29911.yaml
For jobs of ODM program, we usually name it like advantech-ark-1551.yaml
> @@ -0,0 +1,13 @@
> +- project:
> + name: advantech-ark-1551
> + queue: 202201-29911
> + system-id: advantech-ark-1551-c29911
> + series: focal
> + jobs:
> + - '{prefix}-{srutype}-sru-{series}-{flavor}-{system-id}':
> + detail: "Image: {image}\n
> + ADVANTECH ARK-1551 - Anding\n\n
> + Connection Info: [email protected] with a
> registered key"
> + srutype: oem
sru type should be stock.
> + image: 'desktop-20-04-1-uefi'
> + kernel-to-check: linux-generic-hwe-20_04
> diff --git a/jobs/sru/projects/202203-30097.yaml
> b/jobs/sru/projects/202203-30097.yaml
> new file mode 100644
> index 0000000..d7a14b5
> --- /dev/null
> +++ b/jobs/sru/projects/202203-30097.yaml
Please rename it.
> @@ -0,0 +1,14 @@
> +- project:
> + name: adlink-ampere-altra-developer-platform
> + queue: 202203-30097
> + system-id: adlink-ampere-altra-developer-platform-c30097
> + series: focal
> + jobs:
> + - '{prefix}-{srutype}-sru-{series}-{flavor}-{system-id}':
> + detail: "Image: Ubuntu 20.04 LTS server image\n
> + Architecture: arm64\n
> + Ampere Altra Developer Platform - Alisan\n\n
> + Connection Info: [email protected] with a
> registered key"
> + srutype: oem
sru type should be stock.
> + image: ''
> + kernel-to-check: linux-generic
> diff --git a/jobs/sru/projects/202205-30314.yaml
> b/jobs/sru/projects/202205-30314.yaml
> new file mode 100644
> index 0000000..650507d
> --- /dev/null
> +++ b/jobs/sru/projects/202205-30314.yaml
Please rename it.
> @@ -0,0 +1,13 @@
> +- project:
> + name: axiomtek-ipc950
> + queue: 202205-30314
we've got at least 3 ipc-950 in the lab5, so shouldn't use the CID as the queue
name.
should be like axiomtek-ipc950
> + system-id: axiomtek-ipc950-c30314
if we have multiple devices in the lab, don't include CID in system-id.
> + series: focal
> + jobs:
> + - '{prefix}-{srutype}-sru-{series}-{flavor}-{system-id}':
> + detail: "Image: {image}\n
> + Axiomtek IPC950 -IPC950\n\n
> + Connection Info: [email protected] with a registered
> key"
> + srutype: oem
should be stock.
> + image: 'desktop-20-04-1-uefi'
> + kernel-to-check: linux-generic-hwe-20_04
> diff --git a/jobs/sru/projects/202207-30436.yaml
> b/jobs/sru/projects/202207-30436.yaml
> new file mode 100644
> index 0000000..6a320b1
> --- /dev/null
> +++ b/jobs/sru/projects/202207-30436.yaml
please rename it.
> @@ -0,0 +1,13 @@
> +- project:
> + name: aaeon-pico-apl3
> + queue: 202207-30436
> + system-id: aaeon-pico-apl3-c30436
> + series: focal
> + jobs:
> + - '{prefix}-{srutype}-sru-{series}-{flavor}-{system-id}':
> + detail: "Image: Ubuntu 20.04 LTS server image\n
> + PICO-APL3 - AAEON PICO-APL3\n\n
> + Connection Info: [email protected] with a
> registered key"
> + srutype: oem
should be stock.
> + image: 'focal'
> + kernel-to-check: linux-generic
--
https://code.launchpad.net/~flyjerry0415/hwcert-jenkins-jobs/+git/hwcert-jenkins-jobs/+merge/439802
Your team hwcert-jenkins is subscribed to branch hwcert-jenkins-jobs:master.
--
Mailing list: https://launchpad.net/~canonical-hw-cert
Post to : [email protected]
Unsubscribe : https://launchpad.net/~canonical-hw-cert
More help : https://help.launchpad.net/ListHelp
