Review: Needs Fixing

While I don't think I have any particular issue with the code itself, I think 
there is a design issue, because the script is called with the apache CGI 
module, which isn't a long-lasting process, meaning the in-memory dict will not 
remain through the various calls. I suggest writing and loading that dict in a 
json file somewhere in `/dev/shm`, that way you'll be able to share it even 
between various parallel requests. Be careful to update the file atomically 
though, with something like a move from a temporary write file.
-- 
https://code.launchpad.net/~uralt/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/470495
Your team Canonical's Ubuntu QA is requested to review the proposed merge of 
~uralt/autopkgtest-cloud:allowed-user-cache into autopkgtest-cloud:master.


-- 
Mailing list: https://launchpad.net/~canonical-ubuntu-qa
Post to     : canonical-ubuntu-qa@lists.launchpad.net
Unsubscribe : https://launchpad.net/~canonical-ubuntu-qa
More help   : https://help.launchpad.net/ListHelp

Reply via email to