On 7/1/08, Jamis Buck <[EMAIL PROTECTED]> wrote: > > The tracker is at: > > http://capistrano.lighthouseapp.com/projects/8716/tickets > > Please do write this up there, and if you can add a patch, that'd be > wonderful, too.
Done - http://capistrano.lighthouseapp.com/projects/8716-capistrano/tickets/32-copy_exclude-patterns-not-globbed-when-copy_cache-not-used > > - Jamis > > > On Jul 1, 2008, at 7:08 AM, Jonathan Share wrote: > > > Hi, > > > > I belive I've just found a bug in the Capistrano copy strategy files > > but I can't find the bug tracker right now. > > > > If you are not using a copy_cache then the following code is run to > > process the exclusions > > > > Line 83 lib/capistrano/recipies/deploy/strategy/copy.rb > > > > copy_exclude.each { |pattern| FileUtils.rm_rf(File.join(destination, > > pattern)) } > > > > Unfortunately rm_rf does not perform filename globbing so nothing gets > > deleted. The correct code would be > > > > copy_exclude.each { |pattern| > > FileUtils.rm_rf(Dir.glob(File.join(destination, pattern))) } > > > > If this looks like an ok fix, I could work on submitting a proper > > patch (with test case), as soon as I manage to get a working dev > > set-up (macports has a too old version of rubygems to install echoe, > > the rubygems dmg package is only for Leopard, I'm on Tiger, and trying > > to set up my ubuntu system also appears to have a too old version of > > rubygems... why does this have to be so difficult?). > > > > Regards, > > > > Jon > > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/capistrano -~----------~----~----~----~------~----~------~--~---
