Patch file

http://github.com/ThePixelDeveloper/capistrano/commit/53418c054331c5dbaaa2e13a636a2e99d87d6d96.patch

and the commit

http://github.com/ThePixelDeveloper/capistrano/commit/53418c054331c5dbaaa2e13a636a2e99d87d6d96

I might have missed some bits. Can someone review this for me and I'll
get it ready for merging.

On Jul 7, 2:47 am, "[email protected]"
<[email protected]> wrote:
> I forgot to add that running the following commands don't have the
> same effect.
>
> git submodule init
> git submodule sync
> git submodule update --recursive
>
> wont recurse into the submodule directories and checkout any
> submodules that reside in them. I'm not sure if this is a git bug or
> not.
>
> On Jul 7, 2:39 am, "[email protected]"
>
>
>
> <[email protected]> wrote:
> > Just to let you guys know. I'm working on a solution. A new
> > configuration option will be used :git_recursive_submodules
>
> > I found space for a bit of code optimization too. Instead of these
> > commands
>
> > execute << "#{git} submodule #{verbose} init"
> > execute << "#{git} submodule #{verbose} sync"
> > execute << "#{git} submodule #{verbose} update #{submodule_recursive}"
>
> > I found out you can pass the --recursive flag to git clone, although
> > this is only if you have submodules and recursion enabled. I see no
> > reason why it should be a configurable option. Any cons to this?
> > Here's the description for the flag:
>
> > After the clone is created, initialize all submodules within, using
> > their default settings. This is equivalent to running git submodule
> > update --init --recursive immediately after the clone is finished.
> > This option is ignored if the cloned repository does not have a
> > worktree/checkout (i.e. if any of --no-checkout/-n, --bare, or --
> > mirror is given)
>
> > On Jun 8, 8:06 pm, "Rafael G." <[email protected]> wrote:
>
> > > Recently I have a problem with Git Submodule Recursive and I had to use
> > > a plugin to solve this problem.
>
> > > I think that this solution(add --recursive option as default) if it
> > > don't produce any  gotcha/error/... it could be a default. Anyway a path
> > > to let add options freely is welcome :)
>
> > > Regards
>
> > > El 08/06/10 09:26, Lee Hambley escribi�:
>
> > > > Mathew,
>
> > > > Sure that works - but a nicer solution would be to allow configurable
> > > > git options via the standard config interface - I might work on that a
> > > > little today and see what come up with.
>
> > > > - Lee
>
> > > > On 8 June 2010 14:30, [email protected]
> > > > <mailto:[email protected]>
> > > > <[email protected]
> > > > <mailto:[email protected]>> wrote:
>
> > > >     Not being a ruby programmer I thought it would be as easy as 
> > > > appending
> > > >     "--recursive" to the command. I'm out of my depth, so I'll have to 
> > > > let
> > > >     someone more qualified do the work (happy to learn how it's done
> > > >     though).
>
> > > >     -Mathew
>
> > > >     On Jun 8, 1:16 pm, Lee Hambley <[email protected]
> > > >     <mailto:[email protected]>> wrote:
> > > >     > Matthew,
>
> > > >     > I need to make this a bigger patch to allow people to set their
> > > >     git options,
> > > >     > as the recursive thing isn't required for everyone � although it
> > > >     does make
> > > >     > sense; happy to work with you on this, or take a patch - your 
> > > > call.
>
> > > >     > - Lee
>
> > > >     > On 8 June 2010 14:05, [email protected]
> > > >     <mailto:[email protected]> <
>
> > > >     > [email protected]
> > > >     <mailto:[email protected]>> wrote:
> > > >     > > Hi there,
>
> > > >     > > Capistrano should be using the "--recursive" argument on "git
> > > >     > > submodule update" to update any nested submodules. I have a few
> > > >     > > scenarios where submodules contain other submodules (usually
> > > >     vendor
> > > >     > > code).
>
> > > >     > > I can create a ticket on lighthouse and create the patch if
> > > >     need be.
>
> > > >     > > Documentation:
> > > >     > 
> > > > >http://www.kernel.org/pub/software/scm/git/docs/git-submodule.html
> > > >     > > Related lines of code:
> > > >     > > -
>
> > > >     
> > > > >http://github.com/capistrano/capistrano/blob/master/lib/capistrano/re...
> > > >     > > -
>
> > > >     
> > > > >http://github.com/capistrano/capistrano/blob/master/lib/capistrano/re...
>
> > > >     > > Kind Regards,
> > > >     > > -Mathew Davies.
>
> > > >     > > --
> > > >     > > * You received this message because you are subscribed to the
> > > >     Google Groups
> > > >     > > "Capistrano" group.
> > > >     > > * To post to this group, send email to
> > > >     [email protected] <mailto:[email protected]>
> > > >     > > * To unsubscribe from this group, send email to
> > > >     > > [email protected]
> > > >     
> > > > <mailto:capistrano%[email protected]><capistrano%2Bunsubscribe
> > > >  @googlegrou
> > > >     ps.com <http://ps.com>>For more options, visit this group at
> > > >     > >http://groups.google.com/group/capistrano?hl=en
>
> > > >     --
> > > >     * You received this message because you are subscribed to the
> > > >     Google Groups "Capistrano" group.
> > > >     * To post to this group, send email to [email protected]
> > > >     <mailto:[email protected]>
> > > >     * To unsubscribe from this group, send email to
> > > >     [email protected]
> > > >     <mailto:capistrano%[email protected]> For more
> > > >     options, visit this group at
> > > >    http://groups.google.com/group/capistrano?hl=en
>
> > > > --
> > > > * You received this message because you are subscribed to the Google
> > > > Groups "Capistrano" group.
> > > > * To post to this group, send email to [email protected]
> > > > * To unsubscribe from this group, send email to
> > > > [email protected] For more options, visit this
> > > > group athttp://groups.google.com/group/capistrano?hl=en
>
> > > --
> > > Rafa

-- 
* You received this message because you are subscribed to the Google Groups 
"Capistrano" group.
* To post to this group, send email to [email protected]
* To unsubscribe from this group, send email to 
[email protected] For more options, visit this group at 
http://groups.google.com/group/capistrano?hl=en

Reply via email to