Unfortunately I doubt I'll have time to debug this myself, even with a machine to use. :/
I think most of the failures likely could be solved by adding "case EINVAL:" next to "case ENOSYS:" (so that the two errors are handled the same) in these two locations: https://github.com/capnproto/capnproto/blob/master/c++/src/kj/filesystem-disk-unix.c++#L1092 https://github.com/capnproto/capnproto/blob/master/c++/src/kj/filesystem-disk-unix.c++#L1121 If you try that out and it helps, send a PR and I'll be happy to merge. I don't think this will fix all the tests, though. The others will require more digging. -Kenton On Tue, Mar 12, 2019 at 12:14 PM Ashwin Kapur <[email protected]> wrote: > Hmm. I suspect there may be something in ZFS affecting the test harness > but not capn proto itself. Test cases for Python3 if compiled from source > fail and it’s the test cases. The Python3 build is fine. The compiler seems > to run fine and the generated code seems to do what it should do. I’ve only > done a basic smoke test of serialization not rpc. > > Would it help if I gave you remote access to the machine? Or is there > something else I can do to help. > > > *---------------------* > *Ashwin Kapur* > Founder & CEO > Reboot Investing Inc > P: (347) 871-7585 > C: (917) 359-3701 > > On Mar 12, 2019, at 2:08 PM, Kenton Varda <[email protected]> wrote: > > Hi Ashwin, > > It does seem likely that these failures are due to using ZFS, yes. > > It looks like possible ZFS does not implement the renameat2() flags and so > returns EINVAL -- we should probably treat this the same as ENOSYS and fall > back to rename(). > > However, it looks like there are also some cases where regular rename() > failed. At first glance I don't have any ideas why that would happen. It > could be a conformance bug in ZFS itself. > > I don't have access to a ZFS machine so I'm not able to debug this myself. > It's possible these bugs could pretty seriously break anything that uses > the KJ filesystem API, which includes in particular the capnp compiler > itself. :/ > > -Kenton > > On Tue, Mar 12, 2019 at 10:57 AM Ashwin Kapur <[email protected]> > wrote: > >> I'm running on Ubuntu 18.04 on a Root ZFS filesystem. I see that the >> failures are mainly to filesystem-disk-test.c++ and I'm wondering if the >> failures have something to do with ZFS. >> >> Thanks. >> >> Ashwin >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Cap'n Proto" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> Visit this group at https://groups.google.com/group/capnproto. >> > > -- You received this message because you are subscribed to the Google Groups "Cap'n Proto" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. Visit this group at https://groups.google.com/group/capnproto.
