Hi all,
The following notes were taken from today's BAM product's code review .
1. Rename the package "*org.wso2.carbon.bam.core.admin*" to relevant
data mapper/data names . Since it doesn't have any admin services.
2. In "org.wso2.carbon.bam.core.dao"
* the class "TenentDAO" has wrong spelling.
* In each class, all methods create a new instance of DSClient
class. Make it a common object.
* Need to refactor DAO class
* Should have better "try catch block" (don't catch specific Exceptions)
3. No need "*org.wso2.carbon.bam.core.data.model*" class, use the
definitions available from the *"org.wso2.carbon.bam.core.data.data"
*class.(should be re factored. Need to keep clear definition )
4. BAMServiceComponent should unregister the Poller service also. (Even
after unregistering the Registry service, polling will run )
* Need to check above mechanism for all other carbon components.?
5. Have to implement Caching logic
6. Remove registry based implementation and go with DB. Save all server
related information at the DB .(Need to survive only with DB.)
7. Should keep registry browser.?
8. Rename
"*org.wso2.carbon.bam.core.persistence.BamRegistryResource*"---->"*org.wso2.carbon.bam.core.persistence.BAMConstants*"
Next Tuesday, remaining bundles in BAM product will be reviewed .
If i missed any points pls add to this thread.
Thanks.
-Ratha.
_______________________________________________
Carbon-dev mailing list
[email protected]
https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
