Anjana Fernando wrote: > Hello, > > Yeah, actually removing the carbon-core parent pom as our > data-services' parent works. Then I just had to add our own dependency > management section in our own parent pom to get some of the > carbon-core bundles (org.wso2.carbon.core, org.wso2.carbon.user.mgt.ui > etc ..) we need and also some orbit-bundles (poi, gdata .. ) . I > guess, that was the main reason for me to have the carbon-parent pom, > because of the dependency-management. But if we are explicitly stating > that info in our own component, then no problem. > +1, that is the correct approach, I saw this issue earlier and was telling this from a long time (no one care it on those days :-)) and now we can see the difficulties that we have to face with the current approach. I suggest changing all the component poms.
I would like to engage in providing the help required for getting this right, lets discuss on next week, (Hopefully - If can make it to office next week) Thanks, Ruwan > Thanks and Regards, > Anjana. > > On Fri, Nov 20, 2009 at 7:42 PM, Ruwan Linton <[email protected]> wrote: > >> HHhhmm, I am not so clear about the problem that you are trying to >> solve, but to me this seems like a workaround for the known issue that >> we are using the carbon parent pom as the parent pom for all the >> components, which is wrong. >> >> Does having a different pom as the parent pom fixes the issue that you >> are trying to resolve?? If so I would say "lets do it right" >> >> Thanks, >> Ruwan >> >> Lahiru Gunathilake wrote: >> >>> Anjana, >>> >>> On Fri, Nov 20, 2009 at 8:44 AM, Anjana Fernando <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> Hi, >>> >>> Well, after this, the carbon version and the data services component >>> wont be in sync. It wont be the same version. So if we are releasing >>> the data services component as 2.0.3 now, maybe in the carbon 2.0.3 >>> release it would be something like 2.0.4. >>> >>> Ok, even thought it's inconsistent .. no idea about some other >>> solution. Good to wait for some feed back. >>> >>> Lahiru >>> >>> >>> Cheers, >>> Anjana. >>> >>> On Fri, Nov 20, 2009 at 8:36 AM, Lahiru Gunathilake >>> <[email protected] <mailto:[email protected]>> wrote: >>> > Anjana, >>> > Are you going to do the release using this approach... ? If yes >>> I think that >>> > is wrong because when we do the actual release after you do the >>> ds release, >>> > dataservices 2.0.3 components will be replaced in the repository and >>> > something wrong can happen when someone build >>> dataservices(2.0.2) after the >>> > carbon 2.0.3 release. >>> > >>> > >>> > >>> > Lahiru >>> > >>> > On Thu, Nov 19, 2009 at 5:51 PM, Anjana Fernando >>> <[email protected] <mailto:[email protected]>> wrote: >>> >> >>> >> Hello, >>> >> >>> >> We are creating a new directory in the data-services carbon >>> component, >>> >> which represents a new version as described by the new branching >>> >> strategy. The new component's version is selected as "2.0.3", >>> and it's >>> >> parents pom has a reference to the carbon-core parents pom with the >>> >> given version "2.0.2". >>> >> >>> >> So by this we are expecting the carbon 2.0.2 libraries to be >>> used by >>> >> the new component. But in carbon-core, the versions are stated >>> there >>> >> as "pom.version", which is expected to pick the version of its pom >>> >> (which is 2.0.2). But when we reference it from our component - >>> which >>> >> has the version 2.0.3 - carbon-core parent treats its >>> "pom.version" as >>> >> "2.0.3". So I'm suggesting to change the carbon-core parent pom >>> to not >>> >> to use the property "pom.version", but to keep a single property >>> >> "wso2carbon.version" with the value "2.0.2" and use it in all the >>> >> places where the version is needed. Here I've attached a diff >>> with the >>> >> changes I suggested. Hope for some feedback. >>> >> >>> >> Thanks, >>> >> Anjana. >>> >> >>> >> _______________________________________________ >>> >> Carbon-dev mailing list >>> >> [email protected] <mailto:[email protected]> >>> >> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >> >>> > >>> > >>> > >>> > -- >>> > Lahiru Gunathilake >>> > Software Engineer - WSO2 Inc. >>> > >>> >>> >>> >>> >>> -- >>> Lahiru Gunathilake >>> Software Engineer - WSO2 Inc. >>> ------------------------------------------------------------------------ >>> >>> _______________________________________________ >>> Carbon-dev mailing list >>> [email protected] >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >> -- >> Ruwan Linton >> Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb >> WSO2 Inc.; http://wso2.org >> email: [email protected]; cell: +94 77 341 3097 >> blog: http://blog.ruwan.org >> >> >> >> > > -- Ruwan Linton Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb WSO2 Inc.; http://wso2.org email: [email protected]; cell: +94 77 341 3097 blog: http://blog.ruwan.org _______________________________________________ Carbon-dev mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
