Hi all, Here is a quick update on the decisions made at the code review.
On Wed, Feb 17, 2010 at 3:47 PM, Dimuthu Gamage <[email protected]> wrote: > 1. RegistryService.java - Remove deprecated methods. getUserRegistry, > getSystemRegistry > Not decided as yet. > 2. Rename the getRegistry to getRootRegistry. (to avoid the confusion). > Not decided as yet. > 3. The argument chroot: the doc comment is not clear. Provide an > example in the doc. > Done. > 4. tenantId argument should be described as a special case of the > tenantId = 0. (the special value) > Done. > 5. EmbeddedRegistryService.java: If the tenantId not provided, put a > note that it returns the super tenant. > Done. > 6. At the registryMount, if the mount point is not available for > governance, config registries, an exception should propagate up. > Done. > 7. RegistryUtils:775 - The log warn should just print the message. Put > another debug log that print the entire exception. > Dome. > 8. Handle the governance, config registries specially when mounting, > so the failures of mounting them will propagate up. > Dome. > 9. "else" should be in the same line as the end bracket of previous > if. (ResourceUtils.java:769). - Good practise. > These are examples of best practices and are not tasks. > 10. If the exception is consuming, name the exception as ignore and > put a comment why it is not thrown up. > These are examples of best practices and are not tasks. > 11. getUserRealm(int tenantId): whether this method should be moved to > user core or not, + how resource should be shared among tenants have > to have different discussion. > Pending. > 12. How to store content across separated registries. To be discussed > more. > Pending. > 13. Currently RegistryAbstractAdmin only have the getRootRegistry(), > Check the posibility whether it should be moved up. To be discussed > more. > Decided to keep this at the registry level. Thanks, Senaka. > > > Thanks > Dimuthu > > _______________________________________________ > Carbon-dev mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > -- Senaka Fernando Software Engineer WSO2 Inc. E-mail: senaka AT wso2.com; Mobile: +94 77 322 1818 http://www.wso2.com/ - "Lean . Enterprise . Middleware"
_______________________________________________ Carbon-dev mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
