Yes, the best code we've seen so far at a code review session. Good job Supun.
Azeez On Tue, Mar 16, 2010 at 3:31 PM, Rajika Kumarasiri <[email protected]> wrote: > These are the code review notes. > > The code was in extremely good quality, with the following minor comments. > > 1. The xml elements name should be in camel case in priority-config.xml. > > 2. Add a single line comment to MultiPriorityBlockingQueue.java:53 > describing the capacity variable. > > Rajika > > On Tue, Mar 16, 2010 at 9:39 AM, Supun Kamburugamuva <[email protected]>wrote: > >> Today (2010/03/16) we will be reviewing Priority Based Mediation >> implementation for ESB, from 2 p.m to 3 p.m >> >> Thanks, >> Supun.. >> >> _______________________________________________ >> Carbon-dev mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> > > > > -- > http://rajikak.blogspot.com/ > > _______________________________________________ > Carbon-dev mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Afkham Azeez Software Architect & Product Manager, WSO2 WSAS; WSO2, Inc.; http://wso2.com Member; Apache Software Foundation; http://www.apache.org/ email: [email protected] cell: +94 77 3320919 blog: http://afkham.org twitter: http://twitter.com/afkham_azeez linked-in: http://lk.linkedin.com/in/afkhamazeez Lean . Enterprise . Middleware
_______________________________________________ Carbon-dev mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
