Samisa Abeysinghe wrote: > > > On Thu, Apr 1, 2010 at 9:13 AM, Sameera Jayasoma <same...@wso2.com > <mailto:same...@wso2.com>> wrote: > > > > On Thu, Apr 1, 2010 at 7:22 AM, Ruwan Linton <ru...@wso2.com > <mailto:ru...@wso2.com>> wrote: > > Sameera Jayasoma wrote: > > > > > > On Thu, Apr 1, 2010 at 6:42 AM, Sameera Jayasoma > <same...@wso2.com <mailto:same...@wso2.com> > > <mailto:same...@wso2.com <mailto:same...@wso2.com>>> wrote: > > > > > > > > On Thu, Apr 1, 2010 at 6:33 AM, Ruwan Linton > <ru...@wso2.com <mailto:ru...@wso2.com> > > <mailto:ru...@wso2.com <mailto:ru...@wso2.com>>> wrote: > > > > First of all, we were planning to do the code-freeze > today :-( > > I don't > > think this change is acceptable.. if we are to keep > the code > > freeze date > > unchanged. > > > > > > There is a Jira reported for fixing licenses. > > https://wso2.org/jira/browse/CARBON-7009 > > When you are fixing license file path, you can also > have a look > > at other items. :) > > > > > > These items shouldn't take much time. You got to do some > work in items > > 1,2,3 and for 4,5,6 you just need to check whether things > has been > > done properly. > > > > Thanks > > Sameera > > > > > > Sameera > > > > > > Sameera Jayasoma wrote: > > > Hi Carbon Component Owners, > > > > > > Following work items should be completed by each > and every > > component > > > owner. > > > > > > Here I've taken logging mgt feature as an example. > Say it > > contains 4 > > > features, composite, server, ui and common features. > > > > > > *1) Feature names should be changed in the > following manner* > > > > > > WSO2 Carbon - Logging Management Feature > > > --WSO2 Carbon - Logging Management Server Feature > > > --WSO2 Carbon - Logging Management UI Feature > > > --WSO2 Carbon - Logging Management Common Feature > > > > > Is this '--' thing has to be part of the name?? > > > Sameera, what about the above? > > BTW: I am sorry but we cannot do changes to the features on > the day we > code freeze (From our past experience we know what the impact > is). IMHO, > we cannot code freeze today. > > > If we are not code freezing, can we do this? Of-course... > > I think this is required for patching??? Yes, I understand... lets do these, and wait till the next build to see what is the impact. :-)
Thanks, Ruwan > > Samisa... > > > > Also, it is not about the time it takes to do these, but the > impact on > the whole system. :-( > > > These changes won't impact the system. I've request only to change > Feature Name, Description and feature.properties file location. > These won't affect the product builds. If we are gonna release P2 > repo, we need to better feature names, descriptions, license and > copyright information. > > I've already performed all the other work and I've requested only > to verify whether they are correct. > > Sameera > > > Ruwan > > > > > > I didn't read through all... will ask more questions > when I do > > so :-) > > > > Thanks, > > Ruwan > > > > > > *2) Add meaningful feature descriptions.* > > > Fill <description> tag in pom.xml. Feature > descriptions are > > available > > > for most of the features in this > > > > > > > document(http://wso2.org/projects/carbon/provisioning-wso2-carbon-with-equinox-p2) > > > > > > *3) Fix feature.properties file location* > > > feature.properties file contains license and copyright > > information. > > > Each and every feature should carry this file. > This file is > > located in > > > features project under the etc/ folder. Relative > path to > > > feature.properties file should be added to the > <propertiesFile> > > > element of carbon-p2-plugin. Some feature may have > to use long > > > relative paths. :) I could only think of this > solution at > > this moment. > > > Please suggest if you have a better solution. > > > > > > > > > > <propertiesFile>../../../../../../../etc/feature.properties</propertiesFile> > > > > > > *4) Usage of org.wso2.carbon.p2.category.type > property* > > > This property is used to mark a feature as a > server, common > > or console > > > feature. If the feature is a server feature, following > > configuration > > > element should be added to the carbon-p2-plugin. > > > > > > <adviceFile> > > > <properties> > > > > > > <propertyDef>org.wso2.carbon.p2.category.type:server</propertyDef> > > > </properties> > > > </adviceFile> > > > > > > Likewise you can add any number of properties > under the > > properties > > > element. > > > > > > *5) Usage of org.eclipse.equinox.p2.type.group > property* > > > By default all the features are considered as > group/top > > level features > > > in Equinox P2. When you query a P2 repository what > you get > > is a list > > > of group features. But ideally we should only show > the composite > > > feature as top level features. Other features > should be > > showen as > > > child features in the tree-view. Otherwise there > will be > > long list of > > > features. > > > > > > Therefore we need to set the above property to > false in server, > > > console, common features in the following manner. This > > property is > > > added to server/console/common features only if > they have a > > composite > > > feature. I've seen some server features which does > not have a > > > composite feature. Please don't add this property > in such cases. > > > > > > <adviceFile> > > > <properties> > > > > > > <propertyDef>org.eclipse.equinox.p2.type.group:false</propertyDef> > > > </properties> > > > </adviceFile> > > > > > > I've added bot the above properties to all the > features. But > > please > > > check whether they have been added correctly. > > > > > > *6) Usage of <bundleDef> and <importBundleDef>* > > > > > > Both these element are used to declare required > bundles in > > features. I > > > will explain the usage of these elements using the > following > > example. > > > > > > Security mgt feature has a dependency on xkms > bundle and > > also XKMS > > > feature has a dependency on xkms bundle. Ideally > xkms bundle > > should be > > > a part of the XKMS feature and other features > should import xkms > > > feature using <importFeatureDef> element. Now when > you install > > > security mgt feature, xkms feature will also get > installed, > > because it > > > is required feature of security mgt. But xkms > feature may > > contain some > > > other bundles which are not required for Security > mgt. Hence > > importing > > > the complete xkms feature would not solve the > problem. In > > these cases, > > > you can use importBundleDef element to import only > the xkms > > bundle > > > from xkms feature. > > > > > > Each and every bundle used in Carbon based > products, should > > belongs to > > > a SINGLE feature and dependencies on these bundles > should be > > declared > > > using <bundleDef> element. Other features can > either import > > complete > > > features or import bundles. > > > > > > We need to enforce this fact in our Carbon > features. If not, > > it causes > > > issues when *patching features*. Therefore please > make sure > > that you > > > have declared dependencies on bundles and features > correctly. > > > > > > If you have any concerns on this, please let us know. > > > > > > Thanks > > > Sameera > > > > > > > > > > > > > ------------------------------------------------------------------------ > > > > > > _______________________________________________ > > > Carbon-dev mailing list > > > Carbon-dev@wso2.org <mailto:Carbon-dev@wso2.org> > <mailto:Carbon-dev@wso2.org <mailto:Carbon-dev@wso2.org>> > > > > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > > > > > > > > -- > > Ruwan Linton > > Technical Lead & Product Manager; WSO2 ESB; > http://wso2.org/esb > > WSO2 Inc.; http://wso2.org > > phone: +1 408 754 7388 ext 51789 > > email: ru...@wso2.com <mailto:ru...@wso2.com> > <mailto:ru...@wso2.com <mailto:ru...@wso2.com>>; cell: +94 77 > > 341 3097 > > blog: http://blog.ruwan.org > > > > Lean . Enterprise . Middleware > > > > > > _______________________________________________ > > Carbon-dev mailing list > > Carbon-dev@wso2.org <mailto:Carbon-dev@wso2.org> > <mailto:Carbon-dev@wso2.org <mailto:Carbon-dev@wso2.org>> > > > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > > > > > > > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > Carbon-dev mailing list > > Carbon-dev@wso2.org <mailto:Carbon-dev@wso2.org> > > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > > > > -- > Ruwan Linton > Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb > WSO2 Inc.; http://wso2.org > phone: +1 408 754 7388 ext 51789 > email: ru...@wso2.com <mailto:ru...@wso2.com>; cell: +94 77 > 341 3097 > blog: http://blog.ruwan.org > > Lean . Enterprise . Middleware > > > _______________________________________________ > Carbon-dev mailing list > Carbon-dev@wso2.org <mailto:Carbon-dev@wso2.org> > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > > > _______________________________________________ > Carbon-dev mailing list > Carbon-dev@wso2.org <mailto:Carbon-dev@wso2.org> > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > Samisa... > -- > blog: http://samisa-abeysinghe.blogspot.com/ > > > ------------------------------------------------------------------------ > > _______________________________________________ > Carbon-dev mailing list > Carbon-dev@wso2.org > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > -- Ruwan Linton Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb WSO2 Inc.; http://wso2.org phone: +1 408 754 7388 ext 51789 email: ru...@wso2.com; cell: +94 77 341 3097 blog: http://blog.ruwan.org Lean . Enterprise . Middleware _______________________________________________ Carbon-dev mailing list Carbon-dev@wso2.org https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
