On Fri, Jun 4, 2010 at 10:49 AM, Afkham Azeez <[email protected]> wrote:

> Isuru,
> Have you incorporated all the code review recommendations? If not, please
> mention which items have been left out and by when the pending items can be
> completed.
>

All are done.

Thanks,
~Isuru


>
> Thanks
> Azeez
>
> On Wed, Feb 24, 2010 at 5:03 PM, Sameera Jayasoma <[email protected]>wrote:
>
>> Here are the notes from this code review.
>>
>> 1) Remove the CommonPersistanceManager class, if there are no usages of
>> it. If there are usages, rename is as MiscPM.
>>
>> 2) move addPolicyResources(), setResourcePolicyID() method in AbstractPM
>> to ServicePM class.
>>
>> 3) RegistryResources class contain constants, hence name is inappropriate
>>
>> 4) Put debug level messages in proper places.
>>
>> 5) Improve logging. remove handleDebug() method in every PM
>> implementations.
>>
>> Thanks
>> Sameera
>>
>>
>> On Wed, Feb 24, 2010 at 9:27 AM, Isuru Suriarachchi <[email protected]>wrote:
>>
>>> Hi all,
>>>
>>> This will be held today from 2-3 PM. Please be there on time.
>>>
>>> Thanks,
>>> ~Isuru
>>>
>>> On Thu, Feb 18, 2010 at 11:23 AM, Afkham Azeez <[email protected]> wrote:
>>>
>>>> Owner: Isuru
>>>> Scribe: Sameera
>>>> Area: Persistence management
>>>>
>>>> Thanks
>>>> --
>>>> Afkham Azeez
>>>> Software Architect & Product Manager, WSO2 WSAS; WSO2, Inc.;
>>>> http://wso2.com
>>>> Member; Apache Software Foundation; http://www.apache.org/
>>>> email: [email protected] cell: +94 77 3320919
>>>> blog: http://afkham.org
>>>> twitter: http://twitter.com/afkham_azeez
>>>> linked-in: http://lk.linkedin.com/in/afkhamazeez
>>>>
>>>> _______________________________________________
>>>> Carbon-dev mailing list
>>>> [email protected]
>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>>
>>>>
>>>
>>> _______________________________________________
>>> Carbon-dev mailing list
>>> [email protected]
>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>
>>>
>>
>> _______________________________________________
>> Carbon-dev mailing list
>> [email protected]
>> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>>
>
>
> --
> Afkham Azeez
> Senior Software Architect & Product Manager, WSO2 WSAS; WSO2, Inc.;
> http://wso2.com, Lean . Enterprise . Middleware
>
> Member; Apache Software Foundation; http://www.apache.org/
> email: [email protected] cell: +94 77 3320919
> blog: http://blog.afkham.org
>
> twitter: http://twitter.com/afkham_azeez
> linked-in: http://lk.linkedin.com/in/afkhamazeez
>
> _______________________________________________
> Carbon-dev mailing list
> [email protected]
> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>
_______________________________________________
Carbon-dev mailing list
[email protected]
https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Reply via email to