Dumindu/Ratha, Please respond! Azeez
On Fri, Jun 4, 2010 at 11:00 AM, Afkham Azeez <[email protected]> wrote: > Dumindu, > Have you incorporated all the code review recommendations? If not, please > mention which items have been left out and by when the pending items can be > completed. > > Thanks > Azeez > > On Thu, Oct 29, 2009 at 10:06 AM, Afkham Azeez <[email protected]> wrote: > >> Dumindu, >> Please provide a deadline by which you will be able to complete the >> enhancements that we discussed during the code review. >> >> Azeez >> >> On Thu, Oct 29, 2009 at 4:28 AM, ratha <[email protected]> wrote: >> >>> >>> >>> Hi all, >>> >>> Following notes were taken from today's session. >>> >>> 1. Merge *BAM.List* and *BAM.Mgt *bundles with core bundle. >>> >>> * Have only org.wso2.carbon.bam and org.wso2.carbon.bam.ui bundles. >>> >>> 2.BAM.Util--->Constants class should go under core bundle. >>> >>> 3. Mgt.UI >>> >>> * pom.xml should not have a <fragment-host> element. Export all the >>> bundles with *carbon ui *header. >>> * i18n all the messages not only in JSPs but also in client classes. >>> * BAMStatqueryDsClient class need to be separated. >>> * BackendServiceURL should point to the service. Remove the >>> operation from ServiceURL in the client class. >>> * Write common client class and share among all other bundles.( >>> gauges&mgt.ui share common client classes) >>> * BAMStatQueryDsclient class has two constructors. Need to remove. >>> * JSPs should handle exception properly. >>> o Before rendering the page, do all the remote calls. >>> o In websphere after deleting a server redirection to the >>> server list page can be done through CarbonUI.utils--->get >>> context root. >>> o Set the error status to 500 . >>> o forward the errors to carbon/error.jsp. >>> >>> Thanks. >>> -Ratha. >>> >>> >>> _______________________________________________ >>> Carbon-dev mailing list >>> [email protected] >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >> >> >> -- >> -- >> Afkham Azeez >> [email protected] >> WSO2 Inc. http://wso2.com >> Blog: http://afkham.org >> > > > > -- > Afkham Azeez > Senior Software Architect & Product Manager, WSO2 WSAS; WSO2, Inc.; > http://wso2.com, Lean . Enterprise . Middleware > > Member; Apache Software Foundation; http://www.apache.org/ > email: [email protected] cell: +94 77 3320919 > blog: http://blog.afkham.org > twitter: http://twitter.com/afkham_azeez > linked-in: http://lk.linkedin.com/in/afkhamazeez > -- Afkham Azeez Senior Software Architect & Product Manager, WSO2 WSAS; WSO2, Inc.; http://wso2.com, Lean . Enterprise . Middleware Member; Apache Software Foundation; http://www.apache.org/ email: [email protected] cell: +94 77 3320919 blog: http://blog.afkham.org twitter: http://twitter.com/afkham_azeez linked-in: http://lk.linkedin.com/in/afkhamazeez
_______________________________________________ Carbon-dev mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
