On Sun, Jun 27, 2010 at 11:20 PM, Senaka Fernando <[email protected]> wrote:
> > > On Sun, Jun 27, 2010 at 9:50 PM, Thilina Mahesh Buddhika < > [email protected]> wrote: > >> >> >> On Sun, Jun 27, 2010 at 8:54 PM, Senaka Fernando <[email protected]> wrote: >> >>> >>> >>> On Sun, Jun 27, 2010 at 8:38 PM, Thilina Mahesh Buddhika < >>> [email protected]> wrote: >>> >>>> >>>> >>>> On Sun, Jun 27, 2010 at 8:29 PM, Senaka Fernando <[email protected]>wrote: >>>> >>>>> >>>>> >>>>> On Sun, Jun 27, 2010 at 8:26 PM, Senaka Fernando <[email protected]>wrote: >>>>> >>>>>> >>>>>> >>>>>> On Sun, Jun 27, 2010 at 8:21 PM, Thilina Mahesh Buddhika < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi Devs, >>>>>>> >>>>>>> At the moment, there are two versions of TenantUtils implementations >>>>>>> available in Carbon Core. >>>>>>> >>>>>>> 1. org.wso2.carbon.core.multitenancy.utils.TenantUtils >>>>>>> 2. org.wso2.carbon.utils.TenantUtils >>>>>>> >>>>>>> I think org.wso2.carbon.core.multitenancy.utils.TenantUtils is the >>>>>>> proper place to have the utility methods and we should get rid of the >>>>>>> second >>>>>>> version, similar to what we did for the MultitenantConstants. >>>>>>> >>>>>> >>>>>> +1. Will do. >>>>>> >>>>> >>>>> There are also some utility methods related to MT in the UM Kernel, >>>>> which we need to move into org.wso2.carbon.utils.TenantUtils. >>>>> >>>> >>>> >>>> +1. IMO, org.wso2.carbon.core.multitenancy.utils.TenantUtils is the >>>> proper place. >>>> >>>> Also org.wso2.carbon.utils.TenantUtils was introduced during the first >>>> phase of MT work and it contains a few utility methods which are mostly >>>> used >>>> by Identity components. So getting rid of this class will have a less >>>> overhead in terms of fixing its usages. >>>> >>> >>> No, IIRC we agreed to move the MT utils (not everything) into >>> org.wso2.carbon.utils. The reason was that Carbon Core has dependencies on >>> the Registry Kernel and the UM Kernel. Since the Registry Kernel and the UM >>> Kernel need MT utilities and constants, in order to avoid the excessive >>> duplication, we decided to maintain the methods inside >>> org.wso2.carbon.utils. Am I missing something here? >>> >>> >> In that case, it has to be org.wso2.carbon.utils.multitenancy.TenantUtils >> to be consistent with other MT code. >> > > Yes. Sorry, for mixing this up. I was meaning > org.wso2.carbon.utils.multitenancy.MultitenantUtils all this time, :-). > Actually, we have moved everything in org.wso2.carbon.utils.TenantUtils into > org.wso2.carbon.utils.multitenancy.MultitenantUtils as well. > > As you can see even at this point in time, it is very confusing. :-).. So, > we need to get this properly organized asap. > Done. Thanks, Senaka. > > Thanks, > Senaka. > >> >> >> >>> Also, wrt fixing usages, the methods of >>> org.wso2.carbon.core.multitenancy.utils.TenantUtils will be deprecated and >>> moved into org.wso2.carbon.utils.TenantUtils, and will be gradually removed. >>> WDYT? >>> >> >> +1. >> >> Thanks, >> Thilina >> >> >>> >>> Thanks, >>> Senaka. >>> >>>> >>>> Thanks, >>>> Thilina >>>> >>>> >>>> >>>>> >>>>> Thanks, >>>>> Senaka. >>>>> >>>>>> >>>>>> Thanks, >>>>>> Senaka. >>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> Thilina >>>>>>> >>>>>>> -- >>>>>>> Thilina Mahesh Buddhika >>>>>>> Senior Software Engineer >>>>>>> WSO2 Inc. ; http://wso2.com >>>>>>> lean . enterprise . middleware >>>>>>> >>>>>>> phone : +94 77 44 88 727 >>>>>>> blog : http://blog.thilinamb.com >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Stratos-dev mailing list >>>>>>> [email protected] >>>>>>> https://wso2.org/cgi-bin/mailman/listinfo/stratos-dev >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Senaka Fernando >>>>>> Associate Technical Lead >>>>>> WSO2 Inc. >>>>>> E-mail: senaka AT wso2.com; Mobile: +94 77 322 1818 >>>>>> >>>>>> http://www.wso2.com/ - "Lean . Enterprise . Middleware" >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Senaka Fernando >>>>> Associate Technical Lead >>>>> WSO2 Inc. >>>>> E-mail: senaka AT wso2.com; Mobile: +94 77 322 1818 >>>>> >>>>> http://www.wso2.com/ - "Lean . Enterprise . Middleware" >>>>> >>>> >>>> >>>> >>>> -- >>>> Thilina Mahesh Buddhika >>>> Senior Software Engineer >>>> WSO2 Inc. ; http://wso2.com >>>> lean . enterprise . middleware >>>> >>>> phone : +94 77 44 88 727 >>>> blog : http://blog.thilinamb.com >>>> >>> >>> >>> >>> -- >>> Senaka Fernando >>> Associate Technical Lead >>> WSO2 Inc. >>> E-mail: senaka AT wso2.com; Mobile: +94 77 322 1818 >>> >>> http://www.wso2.com/ - "Lean . Enterprise . Middleware" >>> >> >> >> >> -- >> Thilina Mahesh Buddhika >> Senior Software Engineer >> WSO2 Inc. ; http://wso2.com >> lean . enterprise . middleware >> >> phone : +94 77 44 88 727 >> blog : http://blog.thilinamb.com >> > > > > -- > Senaka Fernando > Associate Technical Lead > WSO2 Inc. > E-mail: senaka AT wso2.com; Mobile: +94 77 322 1818 > > http://www.wso2.com/ - "Lean . Enterprise . Middleware" > -- Senaka Fernando Associate Technical Lead WSO2 Inc. E-mail: senaka AT wso2.com; Mobile: +94 77 322 1818 http://www.wso2.com/ - "Lean . Enterprise . Middleware"
_______________________________________________ Carbon-dev mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
