I came across the following code.

*public class TenantProcessStoreImpl implements
TenantProcessStore, ConfigurationContextTerminationListener*

 Is there an is-a relationship between TenantProcessStoreImpl
and ConfigurationContextTerminationListener? We should not simply extend
classes or implement interfaces just because we need some behavior in a
class. Like I mentioned during the last code review session, we need to
think twice before naming classes, methods, attributes etc. etc. including
extending classes or implementing interfaces. We cannot afford to forget or
ignore what we learnt in the "Software Engineering 101" classes!

Anyway, I have removed the ConfigurationContextTerminationListener interface
and am using the Axis2ConfigurationContextObserver. So, I'm removing the
"implements ConfigurationContextTerminationListener" from this class since
there interface methods have been removed. Please provide an implementation
of Axis2ConfigurationContextObserver.


Thanks
-- 
Afkham Azeez
Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com,
Lean . Enterprise . Middleware
Member; Apache Software Foundation; http://www.apache.org/
email: [email protected] cell: +94 77 3320919
blog: http://blog.afkham.org
twitter: http://twitter.com/afkham_azeez
linked-in: http://lk.linkedin.com/in/afkhamazeez
_______________________________________________
Carbon-dev mailing list
[email protected]
https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Reply via email to