One more thing I feel worth mentioning is, the huge bulk of unrelated
changes in a single commit. In its commonest form, it comes as "adding a
feature", along with "indentation fixes" or "refactoring", making it almost
impossible locating the specified fix ("adding a feature") in the diff, with
whole bunch of unrelated lines in the commit log.IMHO commits are cheap and to be done more often than in bulk, as it is mentioned, to have 1:1 with the commit log message. Regards, Pradeeban. On Sun, Oct 3, 2010 at 1:39 PM, Afkham Azeez <[email protected]> wrote: > Some more: > > 9. work > 10. temporary fix > 11. svn commit > 12. Fixing the problem > 13. Adding changes > > > > > On Sun, Oct 3, 2010 at 1:24 PM, Afkham Azeez <[email protected]> wrote: > >> Some examples from Carbon commit logs: >> >> 1. >> 2. update >> 3. changes >> 4. minor fix >> 5. fix >> 6. fixing >> 7. disabling tests <-- You need to mention why you are doing something >> like this!!! >> 8. small fix >> >> >> >> >> On Sun, Oct 3, 2010 at 12:03 PM, Afkham Azeez <[email protected]> wrote: >> >>> Also, please don't just add useless commit messages that have no value. >>> >>> Azeez >>> >>> >>> >>> >>> On Sun, Oct 3, 2010 at 12:00 PM, Afkham Azeez <[email protected]> wrote: >>> >>>> I was going through OhLoh commit log messages for Carbon [1] and found >>>> many commits where there are no log messages. This is unacceptable and will >>>> cause issues if we have to go through the commit history to figure out any >>>> issues. Not only do you have to have a commit log message, but also you >>>> have >>>> to run FindBugs before committing! >>>> >>>> >>>> https://www.ohloh.net/p/wso2carbon/commits >>>> >>>> -- >>>> *Afkham Azeez* >>>> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com >>>> , >>>> * >>>> * >>>> *Member; Apache Software Foundation; >>>> **http://www.apache.org/*<http://www.apache.org/> >>>> * >>>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>>> twitter: >>>> **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>>> * >>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >>>> * >>>> * >>>> *Lean . Enterprise . Middleware* >>>> >>>> >>>> >>> >>> >>> -- >>> *Afkham Azeez* >>> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com >>> , >>> * >>> * >>> *Member; Apache Software Foundation; >>> **http://www.apache.org/*<http://www.apache.org/> >>> * >>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>> * >>> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >>> * >>> * >>> *Lean . Enterprise . Middleware* >>> >>> >> >> >> -- >> *Afkham Azeez* >> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com, >> * >> * >> *Member; Apache Software Foundation; >> **http://www.apache.org/*<http://www.apache.org/> >> * >> email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >> * >> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >> * >> * >> *Lean . Enterprise . Middleware* >> >> > > > -- > *Afkham Azeez* > Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com, > * > * > *Member; Apache Software Foundation; > **http://www.apache.org/*<http://www.apache.org/> > * > email: **[email protected]* <[email protected]>* cell: +94 77 3320919 > blog: **http://blog.afkham.org* <http://blog.afkham.org>* > twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> > * > linked-in: **http://lk.linkedin.com/in/afkhamazeez* > * > * > *Lean . Enterprise . Middleware* > > > _______________________________________________ > Carbon-dev mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- Kathiravelu Pradeeban. Software Engineer. WSO2 Inc. Blog: [Llovizna] http://kkpradeeban.blogspot.com/
_______________________________________________ Carbon-dev mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
