Hi all, The very first code review session using Crucible was successful, though it took some time for us to learn how to set it up and use it. There were over 20 people actively reviewing code, and several suggestions were made on how to improve the code quality, and also on refactoring old code.
We learned a few lessons: 1. You can open the idea/eclipse project directly from Crucible, instead of having to set it up in the IDE. 2. No code changes should be made after the crucible project for the review has been created. If not, Crucible will display old revisions. 3. You will need to bring your laptops to actively participate. 4. Make sure to allow anyone to join, so that people can join on their own after the review has begun. We also have a list of benefits: 1. More people took part in reviewing the code, than before. Some were silent during the session, but have added review comments (which is good; but we encourage everybody to speak up). 2. Most of us actually read the code individually instead of simply starring at the projection. 3. We have got much more feedback than former code reviews, which is awesome. 4. When fixing code, it is easy as opening up the review project in the IDE. 5. We might be able to accomodate external reviewers (passive) during the review sessions. I did explain a bit on how to use Crucible, but due to some issue in the resolution of the projected screen, the visual demonstration wasn't quite visible. But, we felt that most us learned how to make use of it (at least in a little way), and actually used it during the session. Many thanks to Ruchira for a well prepared session. We were able to review the entire code (but took ~30mins extra time). Charith was the scribe, and he will post more details on the review itself. Thanks, Senaka. On Mon, Oct 18, 2010 at 10:51 AM, Senaka Fernando <[email protected]> wrote: > Hi all, > > Please note that there will be a demo on how to use crucible in IntelliJ > Idea (using the Atlassian Connector plugin) to review code, during the next > code review session scheduled for tomorrow at 2pm. > > Thanks, > Senaka. > > -- > *Senaka Fernando* > Associate Technical Lead & Product Manager; WSO2, Inc.; http://wso2.com* > Member; Apache Software Foundation; http://apache.org > > E-mail: senaka AT wso2.com > **Phone: +1 408 754 7388; ext: 51736* > *Mobile: +94 77 322 1818 > Linked-In: http://www.linkedin.com/in/senakafernando > > *Lean . Enterprise . Middleware > > -- *Senaka Fernando* Associate Technical Lead & Product Manager - WSO2 G-Reg; WSO2, Inc.; http://wso2.com* Member; Apache Software Foundation; http://apache.org E-mail: senaka AT wso2.com **P: +1 408 754 7388; ext: 51736*; *M: +94 77 322 1818 Linked-In: http://www.linkedin.com/in/senakafernando *Lean . Enterprise . Middleware
_______________________________________________ Carbon-dev mailing list [email protected] https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
