On Thu, Oct 29, 2009 at 9:58 AM, ratha <[email protected]> wrote:
>
>
> Hi all,
>
> Following notes were taken from today's session.
>
> 1. Merge *BAM.List* and *BAM.Mgt *bundles with core bundle.
>
Done .
>
> * Have only org.wso2.carbon.bam and org.wso2.carbon.bam.ui bundles.
>
Done .
>
> 2.BAM.Util--->Constants class should go under core bundle.
>
Done .
>
> 3. Mgt.UI
>
>
> * pom.xml should not have a <fragment-host> element. Export all the
> bundles with *carbon ui *header.
> * i18n all the messages not only in JSPs but also in client classes.
>
Already done .
> * BAMStatqueryDsClient class need to be separated.
>
pending ..
BAMSummaryQueryDSClient class separated.
BAMDataServiceDataProcessor class want to be separated .
These client classes have more than 1900 lines and maintainability is
very less.
> * BackendServiceURL should point to the service. Remove the
> operation from ServiceURL in the client class.
>
Done .
> * Write common client class and share among all other bundles.(
> gauges&mgt.ui share common client classes)
>
Done .
> * BAMStatQueryDsclient class has two constructors. Need to remove.
> * JSPs should handle exception properly.
>
Done .
> o Before rendering the page, do all the remote calls.
>
Fixing..
> o In websphere after deleting a server redirection to the
> server list page can be done through CarbonUI.utils--->get
> context root.
>
Fixing..
> o Set the error status to 500 .
>
Done .
> o forward the errors to carbon/error.jsp.
>
Most of the classes have wrong exception handling.(I'm working to fix these
issue )
Hi all ,
According to the first BAM code review session (28/10/209) I have done
above changes.
Now new BAM component has following packages
org.wso2.carbon.bam.core.
org.wso2.carbon.bam.ui
org.wso2.carbon.bam.common
org.wso2.carbon.bam.util
org.wso2.carbon.bam.cep (This bundle added for BAM CEP integration )
And
*org.wso2.carbon.bam.mgt* and* org.wso2.carbon.bam.mgt.ui* bundles are
removed.
Therefore if you are going to build BAM product plz take a svn up from
bam/component ,bam/feature ,bam/product.
I'm working on complete other pending things.
Thanks
ajithn
_______________________________________________
Carbon-dev mailing list
[email protected]
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
