realmService == null check is necessary!!!


On Mon, Nov 29, 2010 at 10:25 AM, Asela Pathberiya <[email protected]> wrote:

>
>
> On Sun, Nov 28, 2010 at 12:13 AM, Sameera Jayasoma <[email protected]>wrote:
>
>> Hi,
>>
>> The commit [1] has introduced the following change to the TomcatServer
>> class.
>>
>> @@ -295,7 +295,7 @@
>>     }
>>
>>     public void initCarbonContext(Request request) throws Exception {
>> -        if(!isWebappManagementEnabled || realmService == null) {
>> +        if(!isWebappManagementEnabled) {
>>             return;
>>         }
>>         String tenantDomain = getTenantDomain(request);
>>
>> This change has introduced the issue mentioned by Charitha. Please explain
>> reason for this change.
>>
>> I am reverting this change for the moment. Please explain the reason for
>> doing this and fix it properly.
>>
>
>
> Sorry..  it is a big mistake.  my bad : (.   Thanks for pointing out and
> reverting..
>
> I have done some local changes to TomcatServer.java in my machine for some
> testing purpose and when i was committing to secure vault, I have mistakenly
> committed teh TomcatServer.java file (which is not relevant)
>
> Thanks,
> Asela.
>
>
>
>>
>> Thanks
>> Sameera
>>
>> [1] http://wso2.org/svn/browse/wso2?revision=82651&view=revision
>>
>>
>> On Sat, Nov 27, 2010 at 11:19 PM, Sameera Jayasoma <[email protected]>wrote:
>>
>>> Seems like this issue exists in the latest appserver packs also. This
>>> comes from the webapp mgt component. If you remove that component and
>>> restart the product, you can access the mgt console. We are looking into the
>>> issue.
>>>
>>> Thanks
>>> Sameera
>>>
>>>
>>> On Fri, Nov 26, 2010 at 5:09 PM, Charitha Kankanamge 
>>> <[email protected]>wrote:
>>>
>>>> Hi Sameera,
>>>>
>>>> Sorry, this build (AppServer) is unusable. We cannot even access
>>>> management console due to the following NPE.
>>>>
>>>> [2010-11-26 17:05:48,620] ERROR {org.wso2.carbon.server.TomcatServer} -
>>>> Could not handle request: /carbon/
>>>> java.lang.NullPointerException
>>>>     at
>>>> org.wso2.carbon.server.TomcatServer.initCarbonContext(TomcatServer.java:307)
>>>>     at
>>>> org.wso2.carbon.server.TomcatServer$1.invoke(TomcatServer.java:248)
>>>>     at
>>>> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108)
>>>>     at
>>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:151)
>>>>     at
>>>> org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:870)
>>>>     at
>>>> org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:665)
>>>>     at
>>>> org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:528)
>>>>     at
>>>> org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:81)
>>>>     at
>>>> org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:685)
>>>>     at java.lang.Thread.run(Thread.java:619)
>>>> [2010-11-26 17:05:48,693] ERROR {org.wso2.carbon.server.TomcatServer} -
>>>> Could not handle request: /favicon.ico
>>>> java.lang.NullPointerException
>>>>     at
>>>> org.wso2.carbon.server.TomcatServer.initCarbonContext(TomcatServer.java:307)
>>>>     at
>>>> org.wso2.carbon.server.TomcatServer$1.invoke(TomcatServer.java:248)
>>>>     at
>>>> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108)
>>>>     at
>>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:151)
>>>>     at
>>>> org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:870)
>>>>     at
>>>> org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:665)
>>>>     at
>>>> org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:528)
>>>>     at
>>>> org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:81)
>>>>     at
>>>> org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:685)
>>>>
>>>> Regards
>>>> Charitha
>>>>
>>>>
>>>> On Fri, Nov 26, 2010 at 3:47 PM, Sameera Jayasoma <[email protected]>wrote:
>>>>
>>>>> Hi Charitha,
>>>>>
>>>>> Added the Appserver binary and doc distribution to the same location.
>>>>> And also a P2 repository containing features belongs to the appserver is
>>>>> added.
>>>>>
>>>>> Thanks
>>>>> Sameera
>>>>>
>>>>>
>>>>> On Fri, Nov 26, 2010 at 3:18 PM, Charitha Kankanamge <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Sameera,
>>>>>> Could you host the associated P2-repo please? It is essential to test
>>>>>> carbon core.
>>>>>>
>>>>>> Regards
>>>>>> Charitha
>>>>>>
>>>>>> On Fri, Nov 26, 2010 at 12:36 PM, Sameera Jayasoma 
>>>>>> <[email protected]>wrote:
>>>>>>
>>>>>>> Hi Folks,
>>>>>>>
>>>>>>> Chunk 1 release builds are available at
>>>>>>>
>>>>>>> http://builder.wso2.org/~carbon/releases/carbon/3.1.0/latest/<http://builder.wso2.org/%7Ecarbon/releases/carbon/3.1.0/latest/>
>>>>>>>
>>>>>>> Only the Carbon Core distribution is there. Will update the list once
>>>>>>> the other builds are available.
>>>>>>>
>>>>>>> Thanks
>>>>>>> Sameera
>>>>>>>
>>>>>>> --
>>>>>>> Sameera Jayasoma
>>>>>>> Technical Lead and Product Manager, WSO2 Carbon
>>>>>>>
>>>>>>> WSO2, Inc. (http://wso2.com)
>>>>>>> email: [email protected]
>>>>>>> blog: http://tech.jayasoma.org
>>>>>>>
>>>>>>> Lean . Enterprise . Middleware
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Carbon-dev mailing list
>>>>>>> [email protected]
>>>>>>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Carbon-dev mailing list
>>>>>> [email protected]
>>>>>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Sameera Jayasoma
>>>>> Technical Lead and Product Manager, WSO2 Carbon
>>>>>
>>>>> WSO2, Inc. (http://wso2.com)
>>>>> email: [email protected]
>>>>> blog: http://tech.jayasoma.org
>>>>>
>>>>> Lean . Enterprise . Middleware
>>>>>
>>>>> _______________________________________________
>>>>> Carbon-dev mailing list
>>>>> [email protected]
>>>>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>>>
>>>>>
>>>>
>>>> _______________________________________________
>>>> Carbon-dev mailing list
>>>> [email protected]
>>>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>>
>>>>
>>>
>>>
>>> --
>>> Sameera Jayasoma
>>> Technical Lead and Product Manager, WSO2 Carbon
>>>
>>> WSO2, Inc. (http://wso2.com)
>>> email: [email protected]
>>> blog: http://tech.jayasoma.org
>>>
>>> Lean . Enterprise . Middleware
>>>
>>
>>
>>
>> --
>> Sameera Jayasoma
>> Technical Lead and Product Manager, WSO2 Carbon
>>
>> WSO2, Inc. (http://wso2.com)
>> email: [email protected]
>> blog: http://tech.jayasoma.org
>>
>> Lean . Enterprise . Middleware
>>
>> _______________________________________________
>> Carbon-dev mailing list
>> [email protected]
>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>>
>
> _______________________________________________
> Carbon-dev mailing list
> [email protected]
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>


-- 
*Afkham Azeez*
Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com,
*
*
*Member; Apache Software Foundation;
**http://www.apache.org/*<http://www.apache.org/>
*
email: **[email protected]* <[email protected]>* cell: +94 77 3320919
blog: **http://blog.afkham.org* <http://blog.afkham.org>*
twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
*
linked-in: **http://lk.linkedin.com/in/afkhamazeez*
*
*
*Lean . Enterprise . Middleware*
_______________________________________________
Carbon-dev mailing list
[email protected]
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Reply via email to