On Mon, Dec 13, 2010 at 8:57 PM, Afkham Azeez <az...@wso2.com> wrote:
> Was FindBugs run on this code? It does not look like it was run :( We should not review any code that was not run through find bugs. It is a waste of time. It should be the first step in the review that the code owner run find bugs and show to others at the start of the review. > > On Mon, Dec 13, 2010 at 8:31 PM, Afkham Azeez <az...@wso2.com> wrote: > >> Please revisit the Crucible component and check out my comments. There are >> several convention violations in some of this code. Please take a look and >> fix it ASAP. >> >> Thanks >> Azeez >> >> >> On Mon, Dec 13, 2010 at 12:09 PM, Hasini Gunasinghe <has...@wso2.com>wrote: >> >>> Notes of this code review was recorded in the crucible project itself and >>> the link for the crucible project is: >>> https://wso2.org/crucible/cru/COMPONENT-14 >>> >>> On Fri, Dec 10, 2010 at 12:42 PM, Harshana Martin <harsh...@wso2.com>wrote: >>> >>>> This event has been changed. >>>> more details >>>> »<https://www.google.com/calendar/event?action=VIEW&eid=anI3ZWNodThkcHZjMmQ3cTR1YjdvZHUzOTQgY2FyYm9uLWRldkB3c28yLm9yZw&tok=MTcjaGFyc2hhbmFAd3NvMi5jb21lM2UzY2FiYTJjMDYwYjg5Y2I5NDNmYWQ4ZmJiNjE1ZGFlZGVhNjEz&ctz=Asia%2FColombo&hl=en> >>>> Group A - Code Review >>>> *Changed: *This core review will be on Ant and Maven integration with >>>> C-App. You can find the crucible project for the core view at >>>> https://wso2.org/crucible/cru/COMPONENT-14<http://www.google.com/url?q=https%3A%2F%2Fwso2.org%2Fcrucible%2Fcru%2FCOMPONENT-14&usd=2&usg=AFQjCNGhO9MUa59zekdSzA3O1zIDSao0JQ> >>>> . >>>> *When* >>>> Mon Dec 13 10am – 11:30am Colombo >>>> *Where* >>>> 3rd Floor (map <http://maps.google.com/maps?q=3rd+Floor+&hl=en>) >>>> *Calendar* >>>> carbon-dev@wso2.org >>>> *Who* >>>> • >>>> Harshana Martin - organizer >>>> • >>>> Selvaratnam Uthaiyashankar >>>> • >>>> Supun Kamburugamuwa >>>> • >>>> carbon-dev@wso2.org >>>> >>>> Going? >>>> *Yes<https://www.google.com/calendar/event?action=RESPOND&eid=anI3ZWNodThkcHZjMmQ3cTR1YjdvZHUzOTQgY2FyYm9uLWRldkB3c28yLm9yZw&rst=1&tok=MTcjaGFyc2hhbmFAd3NvMi5jb21lM2UzY2FiYTJjMDYwYjg5Y2I5NDNmYWQ4ZmJiNjE1ZGFlZGVhNjEz&ctz=Asia%2FColombo&hl=en>- >>>> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=anI3ZWNodThkcHZjMmQ3cTR1YjdvZHUzOTQgY2FyYm9uLWRldkB3c28yLm9yZw&rst=3&tok=MTcjaGFyc2hhbmFAd3NvMi5jb21lM2UzY2FiYTJjMDYwYjg5Y2I5NDNmYWQ4ZmJiNjE1ZGFlZGVhNjEz&ctz=Asia%2FColombo&hl=en>- >>>> No<https://www.google.com/calendar/event?action=RESPOND&eid=anI3ZWNodThkcHZjMmQ3cTR1YjdvZHUzOTQgY2FyYm9uLWRldkB3c28yLm9yZw&rst=2&tok=MTcjaGFyc2hhbmFAd3NvMi5jb21lM2UzY2FiYTJjMDYwYjg5Y2I5NDNmYWQ4ZmJiNjE1ZGFlZGVhNjEz&ctz=Asia%2FColombo&hl=en> >>>> * more options >>>> »<https://www.google.com/calendar/event?action=VIEW&eid=anI3ZWNodThkcHZjMmQ3cTR1YjdvZHUzOTQgY2FyYm9uLWRldkB3c28yLm9yZw&tok=MTcjaGFyc2hhbmFAd3NvMi5jb21lM2UzY2FiYTJjMDYwYjg5Y2I5NDNmYWQ4ZmJiNjE1ZGFlZGVhNjEz&ctz=Asia%2FColombo&hl=en> >>>> >>>> Invitation from Google Calendar <https://www.google.com/calendar/> >>>> >>>> You are receiving this courtesy email at the account >>>> carbon-dev@wso2.org because you are an attendee of this event. >>>> >>>> To stop receiving future notifications for this event, decline this >>>> event. Alternatively you can sign up for a Google account at >>>> https://www.google.com/calendar/ and control your notification settings >>>> for your entire calendar. >>>> >>>> _______________________________________________ >>>> Carbon-dev mailing list >>>> Carbon-dev@wso2.org >>>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>>> >>>> >>> >>> _______________________________________________ >>> Carbon-dev mailing list >>> Carbon-dev@wso2.org >>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev >>> >>> >> >> >> -- >> *Afkham Azeez* >> Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com, >> * >> * >> *Member; Apache Software Foundation; >> **http://www.apache.org/*<http://www.apache.org/> >> * >> email: **az...@wso2.com* <az...@wso2.com>* cell: +94 77 3320919 >> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >> * >> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >> * >> * >> *Lean . Enterprise . Middleware* >> >> > > > -- > *Afkham Azeez* > Senior Software Architect & Senior Manager; WSO2, Inc.; http://wso2.com, > * > * > *Member; Apache Software Foundation; > **http://www.apache.org/*<http://www.apache.org/> > * > email: **az...@wso2.com* <az...@wso2.com>* cell: +94 77 3320919 > blog: **http://blog.afkham.org* <http://blog.afkham.org>* > twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> > * > linked-in: **http://lk.linkedin.com/in/afkhamazeez* > * > * > *Lean . Enterprise . Middleware* > > > _______________________________________________ > Carbon-dev mailing list > Carbon-dev@wso2.org > https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > Thanks, Samisa... Samisa Abeysinghe VP Engineering WSO2 Inc. http://wso2.com http://wso2.org
_______________________________________________ Carbon-dev mailing list Carbon-dev@wso2.org https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
