*General Comments on the review*
1. In Submit.jsp -
framework usage vialation - Use file upload executors.
2. Rename CloudAdminService.java to CsgAdminService.java
3. Describe Java doc parameters
4. Rename Constants.java to CSGConstants.java
5. Rename services.jsp to cloudServicesGateway.jsp
6. Remove org.wso2.carbon.csg.ssh package
7. Use Constants instead of String parameters.
8. Don't throw exceptions in jsp as the error stack appear in ui. Should
handle in a proper way.
9. FE messages should be internationalized.
Other comments are recorded in the Crucible project itself (
https://wso2.org/crucible/cru/COMPONENT-16 ) .
On Wed, Dec 15, 2010 at 6:23 AM, Ranga Siriwardena <[email protected]> wrote:
> This event has been changed.
> more details
> »<https://www.google.com/calendar/event?action=VIEW&eid=dGI5Z3IzaWMyNG9pb2FhbGNuOGZudnVrMXMgY2FyYm9uLWRldkB3c28yLm9yZw&tok=MTQjcmFuZ2FAd3NvMi5jb21kZTE2NDc5YzEyYTU4ZjBjOTViYzYxMjlmZDhjNzdlOTBjY2RmZWNm&ctz=Asia%2FColombo&hl=en>
> Group C - CSG code review
> *Changed: *This code review is based on Cloud Service Gateway(CSG) and it
> will review up to xmpp transport based implementation. You can find the
> crucible project from
> https://wso2.org/crucible/cru/COMPONENT-15<http://www.google.com/url?q=https%3A%2F%2Fwso2.org%2Fcrucible%2Fcru%2FCOMPONENT-15&usd=2&usg=AFQjCNHGT19ewFlGWqc4zGwYJPIoRbMwiw>.
>
> (Updated the time to avoid conflict with Training on svn best practices)
> *When*
> *Changed: *Wed Dec 15 1pm – 2pm Colombo
> *Where*
> #59 - 3rd Floor (map<http://maps.google.com/maps?q=%2359+-+3rd+Floor&hl=en>
> )
> *Calendar*
> [email protected]
> *Who*
> •
> Ranga Siriwardena - organizer
> •
> Srinath Perera
> •
> Selvaratnam Uthaiyashankar
> •
> Afkham Azeez
> •
> [email protected]
> •
> Amila Jayasekara
>
> Going?
> *Yes<https://www.google.com/calendar/event?action=RESPOND&eid=dGI5Z3IzaWMyNG9pb2FhbGNuOGZudnVrMXMgY2FyYm9uLWRldkB3c28yLm9yZw&rst=1&tok=MTQjcmFuZ2FAd3NvMi5jb21kZTE2NDc5YzEyYTU4ZjBjOTViYzYxMjlmZDhjNzdlOTBjY2RmZWNm&ctz=Asia%2FColombo&hl=en>-
> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=dGI5Z3IzaWMyNG9pb2FhbGNuOGZudnVrMXMgY2FyYm9uLWRldkB3c28yLm9yZw&rst=3&tok=MTQjcmFuZ2FAd3NvMi5jb21kZTE2NDc5YzEyYTU4ZjBjOTViYzYxMjlmZDhjNzdlOTBjY2RmZWNm&ctz=Asia%2FColombo&hl=en>-
> No<https://www.google.com/calendar/event?action=RESPOND&eid=dGI5Z3IzaWMyNG9pb2FhbGNuOGZudnVrMXMgY2FyYm9uLWRldkB3c28yLm9yZw&rst=2&tok=MTQjcmFuZ2FAd3NvMi5jb21kZTE2NDc5YzEyYTU4ZjBjOTViYzYxMjlmZDhjNzdlOTBjY2RmZWNm&ctz=Asia%2FColombo&hl=en>
> * more options
> »<https://www.google.com/calendar/event?action=VIEW&eid=dGI5Z3IzaWMyNG9pb2FhbGNuOGZudnVrMXMgY2FyYm9uLWRldkB3c28yLm9yZw&tok=MTQjcmFuZ2FAd3NvMi5jb21kZTE2NDc5YzEyYTU4ZjBjOTViYzYxMjlmZDhjNzdlOTBjY2RmZWNm&ctz=Asia%2FColombo&hl=en>
>
> Invitation from Google Calendar <https://www.google.com/calendar/>
>
> You are receiving this courtesy email at the account
> [email protected] you are an attendee of this event.
>
> To stop receiving future notifications for this event, decline this event.
> Alternatively you can sign up for a Google account at
> https://www.google.com/calendar/ and control your notification settings
> for your entire calendar.
>
> _______________________________________________
> Carbon-dev mailing list
> [email protected]
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>
--
Hasini Randika Yatawatte,
Software Engineer.
WSO2 Inc.
_______________________________________________
Carbon-dev mailing list
[email protected]
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
