Indeed very interesting!! – a lot to learn from. Look like Andreas Veithen's code (also http core) (only from the codes I have been familiar with) : java doc as required + a set of suitable abstractions for modeling a solution in terms of abstractions.
If I am correct, Udayanga's code is in [1], and 'Base64EncodeFunction.java' is not part of his code. >From my point of view, I feel that the ‘XpathExtensionUtil’ can be improved (I have not looked at it in details). I see that the number of arguments are higher than 3. You may be agreed or not with it but please have a look at the section 'Function Arguments' in Clean Code, Robert C. Martin. You may identify suitable abstractions to refactor 'XpathExtensionUtil'. I also feel it may be better to refactor the existing ‘Synapse XPath variable implementation’ to use Udayanga‘s new abstraction : ‘SynapseXpathVariableResolver’ - an implementation of 'SynapseXpathVariableResolver’'. Thanks, Indika [1] https://svn.apache.org/repos/asf/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/xpath/ext/ On Sat, Dec 18, 2010 at 8:52 AM, Supun Kamburugamuva <[email protected]> wrote: > Recently Udayanga did an improvement to Synapse XPath extensions. Now a > user can write their own XPath extensions to synapse. > > I just wanted to point out that the code was written nicely with comments > and the coding style was good. It is nice to see good codes contributed to > our projects. > > The code can be found at [1] > > [1] > https://svn.apache.org/repos/asf/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/xpath > > Thanks, > -- > Supun Kamburugamuva > Technical Lead > WSO2 Inc.; http://wso2.org > E-mail: [email protected]; Mobile: +94 77 431 3585 > Blog: http://supunk.blogspot.com > > _______________________________________________ > Carbon-dev mailing list > [email protected] > https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev > >
_______________________________________________ Carbon-dev mailing list [email protected] https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
